Skip to content

Commit 5b556ac

Browse files
committed
Consistently use bash -c in docker exec commands, and use single quotes instead of double quotes to prevent host side shell expansion
1 parent 7b88cc0 commit 5b556ac

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

.github/workflows/build_and_test.yaml

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,19 @@ jobs:
4949
docker exec \
5050
-w ${{ env.FANS_DIR }} \
5151
${{ env.FANS_CONTAINER }} \
52-
bash -c "mkdir -p ${{ env.FANS_BUILD_DIR }}"
52+
bash -c ' \
53+
mkdir -p ${{ env.FANS_BUILD_DIR }} \
54+
'
5355
5456
- name: Configure
5557
run: |
5658
docker exec \
5759
-w ${{ env.FANS_DIR }}/${{ env.FANS_BUILD_DIR }} \
5860
${{ env.FANS_CONTAINER }} \
59-
bash -c " \
61+
bash -c ' \
6062
cmake --version && \
61-
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON .."
63+
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON .. \
64+
'
6265
6366
- uses: actions/upload-artifact@v4
6467
if: failure()
@@ -81,15 +84,19 @@ jobs:
8184
docker exec \
8285
-w ${{ env.FANS_DIR }}/${{ env.FANS_BUILD_DIR }} \
8386
${{ env.FANS_CONTAINER }} \
84-
cmake --build . -j $(nproc) || cmake --build . -j1
87+
bash -c ' \
88+
cmake --build . -j $(nproc) || cmake --build . -j1 \
89+
'
8590
8691
- name: Tests
8792
run: |
8893
docker exec \
8994
-w ${{ env.FANS_DIR }}/${{ env.FANS_BUILD_DIR }} \
9095
-e CTEST_OUTPUT_ON_FAILURE=1 \
9196
${{ env.FANS_CONTAINER }} \
92-
ctest
97+
bash -c ' \
98+
ctest
99+
'
93100
94101
- uses: actions/upload-artifact@v4
95102
if: failure()

0 commit comments

Comments
 (0)