Review comments

Author: Hans-Chrstian

ckanext/fairdatapoint/harvesters/domain/fair_data_point_record_provider.py

@@ -32,7 +32,7 @@ def __init__(self, fdp_end_point: str, harvest_catalogs: bool = False):
     def get_record_ids(self) -> Dict.keys:
         log.debug("FAIR Data Point get_records from {}".format(self.fair_data_point.fdp_end_point))
         result = dict()
-        for fdp_record in self._bfs_traverse_records(self.fair_data_point.fdp_end_point):
+        for fdp_record in self._breath_first_search_records(self.fair_data_point.fdp_end_point):
             if self.harvest_catalogs and fdp_record.is_catalog():
                 identifier = Identifier("")
                 identifier.add("catalog", str(fdp_record.url))
@@ -132,7 +132,7 @@ def _map_record(self, url: str):
         graph = self.fair_data_point.get_graph(url)
         return mapper.map(graph)
 
-    def _bfs_traverse_records(self, start_url: str):
+    def _breath_first_search_records(self, start_url: str):
         queue = deque([start_url])
         visited = set()
         while queue:

ckanext/fairdatapoint/harvesters/domain/fdp_record.py

@@ -8,9 +8,9 @@
 
 class FdpRecord:
     def __init__(self, url, graph):
-        self.graph = graph
         self.url = url
         self._children = set()
+        self._graph = graph
 
     def children(self):
         return self._children
@@ -19,7 +19,7 @@ def add_children(self, child_url):
         self._children.add(child_url)
 
     def is_catalog(self):
-        return (URIRef(self.url), RDF.type, DCAT.Catalog) in self.graph
+        return (URIRef(self.url), RDF.type, DCAT.Catalog) in self._graph
 
     def is_dataset(self):
-        return (URIRef(self.url), RDF.type, DCAT.Dataset) in self.graph
+        return (URIRef(self.url), RDF.type, DCAT.Dataset) in self._graph