fix: Silence Bokeh FIXED_SIZING_MODE warning on hv.save (#6674)

Author: Azaya89

holoviews/plotting/bokeh/util.py

@@ -11,6 +11,7 @@
 from bokeh.core.json_encoder import serialize_json  # noqa (API import)
 from bokeh.core.property.datetime import Datetime
 from bokeh.core.validation import silence
+from bokeh.core.validation.check import is_silenced
 from bokeh.layouts import Column, Row, group_tools
 from bokeh.models import (
     CategoricalAxis,
@@ -546,12 +547,15 @@ def silence_warnings(*warnings):
     """Context manager for silencing bokeh validation warnings.
 
     """
+    silenced = set()
     for warning in warnings:
-        silence(warning)
+        if not is_silenced(warning):
+            silenced.add(warning)
+            silence(warning)
     try:
         yield
     finally:
-        for warning in warnings:
+        for warning in silenced:
             silence(warning, False)
 
 

holoviews/tests/plotting/bokeh/test_save.py

@@ -0,0 +1,27 @@
+import logging
+
+import pytest
+
+import holoviews as hv
+
+
+@pytest.mark.usefixtures("bokeh_backend")
+@pytest.mark.parametrize(
+    "opts",
+    [
+        {"frame_width": 200},
+        {"frame_height": 200},
+        {"frame_height": 200, "frame_width": 200},
+        {},
+    ],
+)
+def test_save_suppresses_bokeh_fixed_sizing_mode(tmp_path, caplog, opts):
+    curve = hv.Curve([1, 2, 3]).opts(**opts, backend="bokeh")
+
+    out = tmp_path / "curve.html"
+    logging.getLogger("bokeh").propagate = True
+    with caplog.at_level(logging.WARNING):
+        hv.save(curve, out)
+
+    assert out.exists()
+    assert all(["FIXED_SIZING_MODE" not in e.msg for e in caplog.records])

holoviews/util/__init__.py

@@ -841,8 +841,16 @@ def save(obj, filename, fmt='auto', backend=None, resources='cdn', toolbar=None,
             fmt = formats[-1]
         if formats[-1] in supported:
             filename = '.'.join(formats[:-1])
-    return renderer_obj.save(obj, filename, fmt=fmt, resources=resources,
-                             title=title)
+    if backend == "bokeh":
+        # Suppress only the specific validator that warns when `sizing_mode='fixed'`
+        # but width/height are not both set on a Bokeh Plot, this happens in HoloViews
+        # when `.opts(fixed_{width,height}=...)` are set,  which sets width/height to `None`.
+        from bokeh.core.validation.warnings import FIXED_SIZING_MODE
+
+        from ..plotting.bokeh.util import silence_warnings
+        with silence_warnings(FIXED_SIZING_MODE):
+            return renderer_obj.save(obj, filename, fmt=fmt, resources=resources, title=title)
+    return renderer_obj.save(obj, filename, fmt=fmt, resources=resources, title=title)
 
 
 def render(obj, backend=None, **kwargs):