Skip to content

Commit ef14f72

Browse files
Remove async void usage
Remove tests using `async void` that shouldn't be.
1 parent 77cfe6d commit ef14f72

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ public async Task ExecuteAsync_EnsurePrimaryContextFlows()
199199
}
200200

201201
[Fact]
202-
public async void ExecuteAsync_EnsureHedgedTasksCancelled_Ok()
202+
public async Task ExecuteAsync_EnsureHedgedTasksCancelled_Ok()
203203
{
204204
// arrange
205205
_testOutput.WriteLine("ExecuteAsync_EnsureHedgedTasksCancelled_Ok executing...");
@@ -658,7 +658,7 @@ ValueTask<Outcome<string>> BackgroundWork(ResilienceContext resilienceContext)
658658
}
659659

660660
[Fact]
661-
public async void ExecuteAsync_ZeroHedgingDelay_EnsureAllTasksSpawnedAtOnce()
661+
public async Task ExecuteAsync_ZeroHedgingDelay_EnsureAllTasksSpawnedAtOnce()
662662
{
663663
// arrange
664664
int executions = 0;

test/Polly.Core.Tests/Retry/RetryResilienceStrategyTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ public override ITimer CreateTimer(TimerCallback callback, object? state, TimeSp
209209
}
210210

211211
[Fact]
212-
public async void OnRetry_EnsureCorrectArguments()
212+
public async Task OnRetry_EnsureCorrectArguments()
213213
{
214214
var attempts = new List<int>();
215215
var delays = new List<TimeSpan>();
@@ -244,7 +244,7 @@ public async void OnRetry_EnsureCorrectArguments()
244244
}
245245

246246
[Fact]
247-
public async void MaxDelay_EnsureRespected()
247+
public async Task MaxDelay_EnsureRespected()
248248
{
249249
var delays = new List<TimeSpan>();
250250
_options.OnRetry = args =>

test/Polly.Extensions.Tests/Issues/IssuesTests.PartitionedRateLimiter_1365.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public partial class IssuesTests
1212
/// Additionally, it also shows how to disable rate limiting for admin users.
1313
/// </summary>
1414
[Fact]
15-
public async void PartitionedRateLimiter_EnsureUserLimited_1365()
15+
public async Task PartitionedRateLimiter_EnsureUserLimited_1365()
1616
{
1717
// arrange
1818
var userKey = new ResiliencePropertyKey<string>("user");

0 commit comments

Comments
 (0)