Skip to content

Commit fb73361

Browse files
committed
remove checkCtx in runSubtask
1 parent 7f90454 commit fb73361

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

pkg/disttask/framework/taskexecutor/task_executor.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -179,21 +179,21 @@ func (e *BaseTaskExecutor) checkBalanceSubtask(ctx context.Context, subtaskCtxCa
179179
}
180180

181181
func (e *BaseTaskExecutor) updateSubtaskSummaryLoop(
182-
checkCtx, runStepCtx context.Context, stepExec execute.StepExecutor) {
182+
subtaskCtx context.Context, stepExec execute.StepExecutor) {
183183
taskMgr := e.taskTable.(*storage.TaskManager)
184184
ticker := time.NewTicker(updateSubtaskSummaryInterval)
185185
defer ticker.Stop()
186186
curSubtaskID := e.currSubtaskID.Load()
187187
update := func() {
188188
summary := stepExec.RealtimeSummary()
189-
err := taskMgr.UpdateSubtaskRowCount(runStepCtx, curSubtaskID, summary.RowCount)
189+
err := taskMgr.UpdateSubtaskRowCount(subtaskCtx, curSubtaskID, summary.RowCount)
190190
if err != nil {
191191
e.logger.Info("update subtask row count failed", zap.Error(err))
192192
}
193193
}
194194
for {
195195
select {
196-
case <-checkCtx.Done():
196+
case <-subtaskCtx.Done():
197197
update()
198198
return
199199
case <-ticker.C:
@@ -434,18 +434,16 @@ func (e *BaseTaskExecutor) runSubtask(subtask *proto.Subtask) (resErr error) {
434434
subtaskCtx, subtaskCtxCancel = context.WithCancel(e.stepCtx)
435435

436436
var wg util.WaitGroupWrapper
437-
checkCtx, checkCancel := context.WithCancel(subtaskCtx)
438437
wg.RunWithLog(func() {
439-
e.checkBalanceSubtask(checkCtx, subtaskCtxCancel)
438+
e.checkBalanceSubtask(subtaskCtx, subtaskCtxCancel)
440439
})
441440

442441
if e.hasRealtimeSummary(e.stepExec) {
443442
wg.RunWithLog(func() {
444-
e.updateSubtaskSummaryLoop(checkCtx, subtaskCtx, e.stepExec)
443+
e.updateSubtaskSummaryLoop(subtaskCtx, e.stepExec)
445444
})
446445
}
447446
defer func() {
448-
checkCancel()
449447
wg.Wait()
450448
subtaskCtxCancel()
451449
}()

0 commit comments

Comments
 (0)