v0.2

Author: LakshmanTurlapati

ReviewGate.mdc

@@ -3,13 +3,13 @@ description:
 globs: 
 alwaysApply: true
 ---
-# AI Agent Protocol: Self-Contained Mandatory Interactive Final Review Loop with Auto-Script Creation
+# AI Agent Protocol: Self-Contained Mandatory Interactive Final Review Loop with Auto-Script Creation (Version 3)
 
 ## 0. User Advisory & Safety:
 This is an advanced, experimental rule. It instructs the AI Agent to check for, potentially create, and then execute a Python script (`final_review_gate.py`) in your project's root directory to facilitate an interactive review loop. By using this rule, you acknowledge that the AI will attempt file system operations (read, write, execute) as directed. Ensure the AI's execution environment has appropriate permissions if you expect script auto-creation to work, and be aware of the security implications.
 
 ## 1. Core Principle & Context:
-Your primary task processing includes a **mandatory final interactive review stage** driven by user input through a specific Python script (`final_review_gate.py`). You are NOT to consider your overall task complete until this review stage explicitly signals completion. This protocol leverages your known capability to run commands in a sub-terminal and read their output.
+Your primary task processing includes a **mandatory final interactive review stage** driven by user input through a specific Python script (`final_review_gate.py`). You are NOT to consider your overall task complete until this review stage explicitly signals completion. This protocol leverages your known capability to run commands in a sub-terminal (displayed within the chat interface) and read their output.
 
 ## Phase 0: Ensure `final_review_gate.py` Script Exists
 (This phase is executed ONCE per user request that triggers this overall protocol, or if the script is missing or its content is incorrect.)
@@ -39,7 +39,7 @@ Your primary task processing includes a **mandatory final interactive review sta
 
             print("--- FINAL REVIEW GATE ACTIVE ---", flush=True)
             print("AI has completed its primary actions. Awaiting your review or further sub-prompts.", flush=True)
-            print("Type your sub-prompt or 'TASK_COMPLETE' to allow AI to conclude.", flush=True)
+            print("Type your sub-prompt, or one of: 'TASK_COMPLETE', 'Done', 'Quit', 'q' to signal completion.", flush=True) # MODIFIED
 
             active_session = True
             while active_session:
@@ -57,14 +57,16 @@ Your primary task processing includes a **mandatory final interactive review sta
 
                     user_input = line.strip()
 
-                    if user_input.upper() == 'TASK_COMPLETE':
-                        print("--- REVIEW GATE: USER CONFIRMED TASK COMPLETE ---", flush=True)
+                    # Check for exit conditions
+                    if user_input.upper() in ['TASK_COMPLETE', 'DONE', 'QUIT', 'Q']: # MODIFIED: Empty string no longer exits
+                        print(f"--- REVIEW GATE: USER SIGNALED COMPLETION WITH '{user_input.upper()}' ---", flush=True)
                         active_session = False
                         break
-                    elif user_input: # If there's any input other than an empty line
+                    elif user_input: # If there's any other non-empty input (and not a completion command)
                         # This is the critical line the AI will "listen" for.
                         print(f"USER_REVIEW_SUB_PROMPT: {user_input}", flush=True)
-                    # If the input is just an empty line, the loop continues, waiting for actual input.
+                    # If user_input was empty (and not a completion command),
+                    # the loop simply continues, and "REVIEW_GATE_AWAITING_INPUT:" will be printed again.
 
                 except KeyboardInterrupt:
                     print("--- REVIEW GATE: SESSION INTERRUPTED BY USER (KeyboardInterrupt) ---", flush=True)
@@ -80,41 +82,45 @@ Your primary task processing includes a **mandatory final interactive review sta
 
 2.  **Ensure Script Existence and Correctness:**
     a.  Use your file system tools to check if the file `final_review_gate.py` exists in the project root.
-    b.  **If the file `final_review_gate.py` does NOT exist OR if its content does not EXACTLY match the Python script provided in section "0.1.Python Script Content" (you may need to read the existing file and compare):**
+    b.  **If the file `final_review_gate.py` does NOT exist OR if its content does not EXACTLY match the Python script provided in section "Phase 0.1.Python Script Content" (you may need to read the existing file and compare):**
         i.  You MUST create or overwrite the `final_review_gate.py` file in the project root.
         ii. The content of this file MUST be *exactly* the Python script content provided above. Ensure all indentation, comments, and lines are preserved perfectly. Use your "create file" or "edit file" tool.
-        iii. After creating/overwriting it, announce: "The `final_review_gate.py` script has been created/updated in the project root."
+        iii. After creating/overwriting it, announce: "The `final_review_gate.py` script has been created/updated in the project root with the latest interaction enhancements."
     c.  **If the file `final_review_gate.py` already exists and its content is correct:** You may skip announcing its creation.
     d.  If you encounter any errors checking for, reading, or creating/writing the file (e.g., permission issues), you MUST report this to the user. State clearly: "Error managing `final_review_gate.py`: [specific error]. Cannot proceed with interactive review." and then conclude the interaction for the main task as best as you can without this interactive step.
 
 ## Phase 1: Primary Task Execution
 1.  Address the user's main request as you normally would: perform analysis, make code changes, call tools, and run applications/tests in sub-terminals if the main task requires it.
+    * **Application Execution Confirmation:** Before attempting to run an entire application (e.g., a web server, a full front-end build, a long-running background process), you MUST ask the user for explicit confirmation. For example: "I am about to run the [application name/command]. Is it okay to proceed, or is it possibly already running?"
+    * This confirmation is NOT required for running individual test scripts, linters, build tools for specific components, or other non-application-level commands necessary for task completion.
+    * If the user indicates an application is already running or denies permission, adapt your strategy accordingly (e.g., focus on tests or specific file executions).
 2.  Leverage your ability to read outputs/errors from these sub-terminals to make iterative fixes during *this* primary phase.
+
 ## Phase 2: Mandatory Final Interactive Review Script Execution
 1.  **Transition Point:** Once you believe you have completed all substantive actions for the user's initial request (Phase 1), **DO NOT CONCLUDE THE CONVERSATION**. You MUST now transition to this Final Interactive Review phase.
-2.  **Action:** Execute the `final_review_gate.py` script (which you ensured exists and is correct in Phase 0) from the project root. Determine the correct Python interpreter command (e.g., `python`, `python3`) available in the execution environment. A robust command attempt would be `python3 ./final_review_gate.py` and if that fails, try `python ./final_review_gate.py`.
-3.  **Announcement:** Clearly inform the user: "I have completed the primary actions. Now initiating the mandatory Final Interactive Review by running `./final_review_gate.py`. The review terminal is now active. Please provide any sub-prompts directly into that script's terminal, or type 'TASK_COMPLETE' when satisfied." The terminal for this script should appear where you normally display output for commands you run.
+2.  **Action:** Execute the `final_review_gate.py` script (which you ensured exists and is correct in Phase 0) from the project root.
+    * Determine the correct Python interpreter command (e.g., `python`, `python3`) available in the execution environment. A robust command attempt would be `python3 ./final_review_gate.py` and if that fails, try `python ./final_review_gate.py`.
+    * **Crucially, the terminal for this script MUST run directly within the chat window, and its output MUST be continuously visible to the user as it is generated.** It must NOT pop open as a separate window or run hidden in the background. You MUST wait for the script (and its terminal interaction) to fully complete and exit before you proceed with any further actions or attempt to conclude the overall task. Your processing will be blocked by this script's execution.
+3.  **Announcement:** Clearly inform the user: "I have completed the primary actions. Now initiating the mandatory Final Interactive Review by running `./final_review_gate.py`. The review terminal is now active **in this chat window, and its output will be displayed live**. Please provide any sub-prompts directly into that script's input area, or type 'TASK_COMPLETE', 'Done', 'Quit', or 'q' when satisfied." (MODIFIED: Removed "or simply press Enter")
 
 ## Phase 3: Interactive Review Loop (Monitoring Script Output)
-1.  **Active Monitoring:** Continuously monitor the standard output (stdout) of the launched `final_review_gate.py` script. You will "read" its output using the same capability that allows you to read terminal logs or error messages.
+1.  **Active Monitoring & Display:** Continuously monitor the standard output (stdout) of the launched `final_review_gate.py` script **as it appears live in the chat window**. Ensure the user sees all script output, including the `REVIEW_GATE_AWAITING_INPUT:` prompt. You will "read" its output using the same capability that allows you to read terminal logs or error messages. The script will loop and re-prompt if an empty input is given.
 2.  **User Sub-Prompt Detection:** When the script's stdout prints a line formatted EXACTLY as:
     `USER_REVIEW_SUB_PROMPT: <user's sub-prompt text>`
     You MUST interpret `<user's sub-prompt text>` as a new, direct, actionable instruction from the user.
 3.  **Processing Sub-Prompts:**
     a.  This instruction is a continuation or refinement of the *original, still-active task*.
-    b.  Analyze the sub-prompt. Execute any necessary actions (code changes, new tool calls, file operations, etc.). **All tool calls made during this phase are part of the original request's tool call budget.**
+    b.  Analyze the sub-prompt. Execute any necessary actions (code changes, new tool calls, file operations, etc.). **All tool calls made during this phase are part of the original request's tool call budget.** If the sub-prompt requests running an entire application, the confirmation principle from "Phase 1, Step 1 (Application Execution Confirmation)" applies.
     c.  Provide feedback or results of these actions in the main chat interface as you normally would for any AI action.
-    d.  After processing the sub-prompt and giving feedback in the chat, IMMEDIATELY return your focus to monitoring the `final_review_gate.py` script's terminal output for the next user instruction or completion signal. This loop is critical.
-4.  **Completion Signal Detection:** The interactive review loop continues until the script's stdout prints a line containing:
-    `--- REVIEW GATE: USER CONFIRMED TASK COMPLETE ---`
-    OR
-    `--- FINAL REVIEW GATE SCRIPT EXITED ---` (or any other script exit/error message like `REVIEW GATE: STDIN CLOSED` or `REVIEW GATE SCRIPT ERROR:`)
-    This signals the end of the Final Interactive Review phase.
+    d.  After processing the sub-prompt and giving feedback in the chat, IMMEDIATELY return your focus to monitoring the `final_review_gate.py` script's terminal output (which remains live and visible in the chat) for the next user instruction or completion signal. This loop is critical.
+4.  **Completion Signal Detection:** The interactive review loop continues until the script's stdout (visible in the chat window) prints a line containing:
+    * `--- REVIEW GATE: USER SIGNALED COMPLETION WITH 'TASK_COMPLETE' ---` (or 'DONE', 'QUIT', 'Q' as per script logic)
+    * OR `--- FINAL REVIEW GATE SCRIPT EXITED ---` (or any other script exit/error message like `REVIEW GATE: STDIN CLOSED` or `REVIEW GATE SCRIPT ERROR:`)
+    (MODIFIED: Removed specific "EMPTY INPUT RECEIVED" as a completion signal, as the script no longer behaves this way for completion.)
 
 ## Phase 4: True Task Conclusion
-1.  Only after the `final_review_gate.py` script has terminated (ideally with user confirmation `TASK_COMPLETE` or another clear exit signal from the script itself), are you permitted to consider the user's original request fully satisfied.
+1.  Only after the `final_review_gate.py` script has terminated (as observed by its terminal session in the chat window closing and its final exit messages being printed and visible) are you permitted to consider the user's original request fully satisfied.
 2.  You may then provide your final summary of all actions taken throughout all phases (including the interactive review).
 
 ## Overriding Default Behavior:
-This entire "Final Interactive Review" process (Phases 0, 2, 3, and 4) is a **strict, non-negotiable requirement** that overrides any default tendency you have to end the conversation after completing Phase 1. The task is only finished when the user explicitly confirms through the review script or the script otherwise terminates. Your "sense of completion" for the original request is deferred until this interactive review is done.
-
+This entire "Final Interactive Review" process (Phases 0, 2, 3, and 4) is a **strict, non-negotiable requirement** that overrides any default tendency you have to end the conversation after completing Phase 1. The task is only finished when the user explicitly confirms with one of the specified keywords through the review script or the script otherwise terminates due to an error or EOF (as per the defined behavior, including the in-chat, blocking, and continuously visible terminal execution). Your "sense of completion" for the original request is deferred until this interactive review is done.