controllers.js: Don't dereference unknown objects

ferdnyc · ferdnyc · commit 1b2434f18a8a · 2020-08-31T10:41:21.000-04:00
- Seems if(layer_elem) will always be true, even when it refers
  to an unknown element that doesn't have an offset() method.
diff --git a/src/timeline/js/controllers.js b/src/timeline/js/controllers.js
@@ -920,7 +920,7 @@ App.controller("TimelineCtrl", function ($scope) {
 
         // Find element on screen (bound to this layer)
         var layer_elem = $("#track_" + layer.number);
-        if (layer_elem) {
+        if (layer_elem.offset()) {
           // Update the top offset
           layer.y = layer_elem.offset().top + vert_scroll_offset;
         }

Original file line number	Diff line number	Diff line change
`@@ -920,7 +920,7 @@ App.controller("TimelineCtrl", function ($scope) {`
`920`	`920`
`921`	`921`	`// Find element on screen (bound to this layer)`
`922`	`922`	`var layer_elem = $("#track_" + layer.number);`
`923`		`- if (layer_elem) {`
	`923`	`+ if (layer_elem.offset()) {`
`924`	`924`	`// Update the top offset`
`925`	`925`	`layer.y = layer_elem.offset().top + vert_scroll_offset;`
`926`	`926`	`}`