Skip to content

Commit 9717cd3

Browse files
authored
Merge pull request #3988 from OpenShot/mac-builder-fixes-2
Fix Mac OS Git *.log files (on Mac builder)
2 parents 2a3e0a4 + 9bbc8db commit 9717cd3

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

installer/build-mac-dmg.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ mv "$OS_PATH/MacOS/lib/presets" "$OS_PATH/Resources/presets"; ln -s "../../Resou
2828
mv "$OS_PATH/MacOS/lib/profiles" "$OS_PATH/Resources/profiles"; ln -s "../../Resources/profiles" "$OS_PATH/MacOS/lib/profiles";
2929
mv "$OS_PATH/MacOS/lib/resources" "$OS_PATH/Resources/resources"; ln -s "../../Resources/resources" "$OS_PATH/MacOS/lib/resources";
3030
mv "$OS_PATH/MacOS/lib/settings" "$OS_PATH/Resources/settings"; ln -s "../../Resources/settings" "$OS_PATH/MacOS/lib/settings";
31+
mv "$OS_PATH/MacOS/settings/*.log" "$OS_PATH/Resources/settings"; # Copy *.log files into settings
32+
rmdir "$OS_PATH/MacOS/settings/"; # remove settings dir (created by freeze, *.log files)
3133
mv "$OS_PATH/MacOS/lib/tests" "$OS_PATH/Resources/tests"; ln -s "../../Resources/tests" "$OS_PATH/MacOS/lib/tests";
3234
mv "$OS_PATH/MacOS/lib/timeline" "$OS_PATH/Resources/timeline"; ln -s "../../Resources/timeline" "$OS_PATH/MacOS/lib/timeline";
3335
mv "$OS_PATH/MacOS/lib/titles" "$OS_PATH/Resources/titles"; ln -s "../../Resources/titles" "$OS_PATH/MacOS/lib/titles";

installer/fix_qt5_rpath.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,9 @@ def fix_rpath(PATH):
5959
def print_min_versions(PATH):
6060
"""Print ALL MINIMUM and SDK VERSIONS for files in OpenShot build folder.
6161
This does not list all dependent libraries though, and sometimes one of those can cause issues."""
62+
# Use 2 different matches, due to different output from different libraries (depending on compiler)
6263
REGEX_SDK_MATCH = re.compile(r'.*(LC_VERSION_MIN_MACOSX).*version (\d+\.\d+).*sdk (\d+\.\d+).*(cmd)', re.DOTALL)
64+
REGEX_SDK_MATCH2 = re.compile(r'.*sdk\s(.*)\s*minos\s(.*)')
6365
VERSIONS = {}
6466

6567
# Find files matching patterns
@@ -74,9 +76,17 @@ def print_min_versions(PATH):
7476

7577
raw_output = subprocess.Popen(["oTool", "-l", file_path], stdout=subprocess.PIPE).communicate()[0].decode('utf-8')
7678
matches = REGEX_SDK_MATCH.findall(raw_output)
79+
matches2 = REGEX_SDK_MATCH2.findall(raw_output)
80+
min_version = None
81+
sdk_version = None
7782
if matches and len(matches[0]) == 4:
7883
min_version = matches[0][1]
7984
sdk_version = matches[0][2]
85+
elif matches2 and len(matches2[0]) == 2:
86+
sdk_version = matches2[0][0]
87+
min_version = matches2[0][1]
88+
89+
if min_version and sdk_version:
8090
print("... scanning %s for min version (min: %s, sdk: %s)" % (file_path.replace(PATH, ""),
8191
min_version, sdk_version))
8292

@@ -86,7 +96,7 @@ def print_min_versions(PATH):
8696
VERSIONS[min_version].append(file_path)
8797
else:
8898
VERSIONS[min_version] = [file_path]
89-
if min_version in ['10.14', '10.15']:
99+
if min_version in ['11.0']:
90100
print("ERROR!!!! Minimum OS X version not met for %s" % file_path)
91101

92102
print("\nSummary of Minimum Mac SDKs for Dependencies:")
@@ -95,6 +105,9 @@ def print_min_versions(PATH):
95105
for file_path in VERSIONS[key]:
96106
print(" %s" % file_path)
97107

108+
print("\nCount of Minimum Mac SDKs for Dependencies:")
109+
for key in sorted(VERSIONS.keys()):
110+
print("%s (%d)" % (key, len(VERSIONS[key])))
98111

99112
if __name__ == "__main__":
100113
"""Run these methods manually for testing"""

0 commit comments

Comments
 (0)