Skip to content

Commit c5a7005

Browse files
committed
add -P to summarize-gp2040ce invocation and fix a cmake idiom
1 parent fe70399 commit c5a7005

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

patch_board_config.cmake

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@ function (patch_board_config)
2222
COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_SOURCE_DIR}/proto/config.proto ${PROTO_OUTPUT_DIR}
2323
COMMAND ${VENV_BIN_DIR}/concatenate
2424
-P ${PROTO_OUTPUT_DIR}
25-
./build/${PROJECT_NAME}_${CMAKE_PROJECT_VERSION}_${GP2040_BOARDCONFIG}.bin
25+
${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}_${CMAKE_PROJECT_VERSION}_${GP2040_BOARDCONFIG}.bin
2626
--json-board-config-filename ./configs/${GP2040_BOARDCONFIG}/board-config.json
2727
--backup
28-
--new-filename ./build/${PROJECT_NAME}_${CMAKE_PROJECT_VERSION}_${GP2040_BOARDCONFIG}.uf2
28+
--new-filename ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}_${CMAKE_PROJECT_VERSION}_${GP2040_BOARDCONFIG}.uf2
2929
COMMAND ${VENV_BIN_DIR}/summarize-gp2040ce
30-
--filename ./build/${PROJECT_NAME}_${CMAKE_PROJECT_VERSION}_${GP2040_BOARDCONFIG}.uf2
30+
-P ${PROTO_OUTPUT_DIR}
31+
--filename ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}_${CMAKE_PROJECT_VERSION}_${GP2040_BOARDCONFIG}.uf2
3132
COMMENT "Patching binary with board config"
3233
)
3334
endfunction()

0 commit comments

Comments
 (0)