Skip to content

Commit 46a9eb6

Browse files
authored
Merge pull request #504 from ReactiveBayes/dt-fix-pm-rules
Fix q_t1 dimensionality bug
2 parents 30c25a6 + b687d1d commit 46a9eb6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/rules/discrete_transition/predefined/belief_propagation.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@ end
5353
end
5454

5555
# --------------- Rules for 3 interfaces (PointMass q_T1) ---------------
56-
@rule DiscreteTransition(:out, Marginalisation) (m_in::DiscreteNonParametric, q_a::DirichletCollection, q_T1::PointMass{<:AbstractArray{T, 3}}, meta::Any) where {T} = begin
56+
@rule DiscreteTransition(:out, Marginalisation) (m_in::DiscreteNonParametric, q_a::DirichletCollection, q_T1::PointMass{<:AbstractArray{T, 1}}, meta::Any) where {T} = begin
5757
eloga = mean(Base.Broadcast.BroadcastFunction(clamplog), q_a)
5858
@tullio intermediate[i, a] := eloga[i, a, b] * probvec(q_T1)[b]
5959
softmax!(intermediate)
6060
result = intermediate * probvec(m_in)
6161
return Categorical(normalize!(result, 1); check_args = false)
6262
end
6363

64-
@rule DiscreteTransition(:in, Marginalisation) (m_out::DiscreteNonParametric, q_a::DirichletCollection, q_T1::PointMass{<:AbstractArray{T, 3}}, meta::Any) where {T} = begin
64+
@rule DiscreteTransition(:in, Marginalisation) (m_out::DiscreteNonParametric, q_a::DirichletCollection, q_T1::PointMass{<:AbstractArray{T, 1}}, meta::Any) where {T} = begin
6565
eloga = mean(Base.Broadcast.BroadcastFunction(clamplog), q_a)
6666
@tullio intermediate[a, i] := eloga[a, i, b] * probvec(q_T1)[b]
6767
softmax!(intermediate)

0 commit comments

Comments
 (0)