fix(perf): pause animations when not displayed #1323
Merged
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari still calculates rendering for animations that are set with animateTransform, even if they aren't being displayed (svg or parent is `hidden`). This causes performance issues on older devices. We work around this by manually pausing or unpausing the svg depending on whether it's displayed. https://bugs.webkit.org/show_bug.cgi?id=298217 closes #1322
Haroenv
requested review from
a team,
aymeric-giraudet and
shaejaz
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0b4b2a4:
|
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Sep 2, 2025
In Safari, an animation with animateTransform being in the dom (even if hidden) will cause a style recalculation on every frame. This also causes needless processor usage, and slowdown on old devices. This PR solves this issue in instantsearch by preventing rendering of the loading icon if it shouldn't be displayed. - react: remove rendering - js: remove rendering - vue: already not rendering ref: https://bugs.webkit.org/show_bug.cgi?id=298217 ref: algolia/autocomplete#1322 ref: algolia/autocomplete#1323
aymeric-giraudet
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari still calculates rendering for animations that are set with animateTransform, even if they aren't being displayed (svg or parent is
hidden). This causes performance issues on older devices.We work around this by manually pausing or unpausing the svg depending on whether it's displayed.
https://bugs.webkit.org/show_bug.cgi?id=298217
closes #1322