[fix](dump) do not report success if dumping FE image fails (#37508)

dataroaring · dataroaring · commit 141a8c105c08 · 2024-07-17T20:11:12.000+08:00
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
@@ -5564,6 +5564,7 @@ public String dumpImage() {
                 saveImage(dumpFile, journalId);
             } catch (IOException e) {
                 LOG.error("failed to dump image to {}", dumpFilePath, e);
+                return null;
             }
         } finally {
             // unlock all

Original file line number	Diff line number	Diff line change
`@@ -5564,6 +5564,7 @@ public String dumpImage() {`
`5564`	`5564`	`saveImage(dumpFile, journalId);`
`5565`	`5565`	`} catch (IOException e) {`
`5566`	`5566`	`LOG.error("failed to dump image to {}", dumpFilePath, e);`
	`5567`	`+ return null;`
`5567`	`5568`	`}`
`5568`	`5569`	`} finally {`
`5569`	`5570`	`// unlock all`