Skip to content

Commit 91983a7

Browse files
committed
add debug code
1 parent 31b9b5a commit 91983a7

File tree

2 files changed

+30
-3
lines changed

2 files changed

+30
-3
lines changed

fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewRule.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public List<Plan> rewrite(Plan queryPlan, CascadesContext cascadesContext) {
117117
continue;
118118
}
119119
// check mv plan is valid or not
120-
if (!isMaterializationValid(cascadesContext, context)) {
120+
if (!isMaterializationValid(queryPlan, cascadesContext, context)) {
121121
continue;
122122
}
123123
// get query struct infos according to the view strut info, if valid query struct infos is empty, bail out
@@ -836,7 +836,8 @@ protected boolean checkIfRewritten(Plan plan, MaterializationContext context) {
836836
}
837837

838838
// check mv plan is valid or not, this can use cache for performance
839-
private boolean isMaterializationValid(CascadesContext cascadesContext, MaterializationContext context) {
839+
private boolean isMaterializationValid(Plan queryPlan, CascadesContext cascadesContext,
840+
MaterializationContext context) {
840841
long materializationId = context.getMaterializationQualifier().hashCode();
841842
Boolean cachedCheckResult = cascadesContext.getMemo().materializationHasChecked(this.getClass(),
842843
materializationId);
@@ -847,6 +848,9 @@ private boolean isMaterializationValid(CascadesContext cascadesContext, Material
847848
context.recordFailReason(context.getStructInfo(),
848849
"View struct info is invalid", () -> String.format("view plan is %s",
849850
context.getStructInfo().getOriginalPlan().treeString()));
851+
// tmp to location question
852+
LOG.info(String.format("View struct info is invalid, query plan is %s, view plan is %s",
853+
queryPlan.treeString(), context.getStructInfo().getTopPlan().treeString()));
850854
cascadesContext.getMemo().recordMaterializationCheckResult(this.getClass(), materializationId,
851855
false);
852856
return false;
@@ -858,12 +862,16 @@ private boolean isMaterializationValid(CascadesContext cascadesContext, Material
858862
context.recordFailReason(context.getStructInfo(),
859863
"View struct info is invalid", () -> String.format("view plan is %s",
860864
context.getStructInfo().getOriginalPlan().treeString()));
865+
LOG.info(String.format("View struct info is invalid, query plan is %s, view plan is %s",
866+
queryPlan.treeString(), context.getStructInfo().getTopPlan().treeString()));
861867
return false;
862868
}
863869
if (!context.getStructInfo().isValid()) {
864870
context.recordFailReason(context.getStructInfo(),
865871
"View struct info is invalid", () -> String.format("view plan is %s",
866872
context.getStructInfo().getOriginalPlan().treeString()));
873+
LOG.info(String.format("View struct info is invalid, query plan is %s, view plan is %s",
874+
queryPlan.treeString(), context.getStructInfo().getTopPlan().treeString()));
867875
return false;
868876
}
869877
return true;

regression-test/suites/nereids_rules_p0/mv/variant/variant_mv.groovy

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,26 @@ suite("variant_mv") {
415415
where g2.actor['id'] > 34259289 and cast(g1.actor['id'] as int) + cast(g2.repo['id'] as int) > 80000000;
416416
"""
417417
order_qt_query3_0_before "${query3_0}"
418-
check_mv_rewrite_success(db, mv3_0, query3_0, "mv3_0")
418+
419+
sql """DROP MATERIALIZED VIEW IF EXISTS mv3_0"""
420+
sql"""
421+
CREATE MATERIALIZED VIEW mv3_0
422+
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
423+
DISTRIBUTED BY RANDOM BUCKETS 2
424+
PROPERTIES ('replication_num' = '1')
425+
AS ${mv3_0}
426+
"""
427+
428+
def job_name = getJobName(db, "mv3_0");
429+
waitingMTMVTaskFinished(job_name)
430+
431+
def explain_memo_plan = """explain memo plan ${query3_0}"""
432+
logger.info("query3_0 explain memo plan is " + explain_memo_plan.toString())
433+
434+
explain {
435+
sql("${query3_0}")
436+
contains("mv3_0(mv3_0)")
437+
}
419438
order_qt_query3_0_after "${query3_0}"
420439
sql """ DROP MATERIALIZED VIEW IF EXISTS mv3_0"""
421440

0 commit comments

Comments
 (0)