diff --git a/be/src/pipeline/dependency.h b/be/src/pipeline/dependency.h index 8adc24d3b4ed7c..f37766394e09a1 100644 --- a/be/src/pipeline/dependency.h +++ b/be/src/pipeline/dependency.h @@ -761,8 +761,9 @@ struct SetSharedState : public BasicSharedState { // (select 0) intersect (select null) the build side hash table should not // ignore null value. std::vector data_types; - for (const auto& ctx : child_exprs_lists[0]) { - data_types.emplace_back(build_not_ignore_null[0] + for (int i = 0; i < child_exprs_lists[0].size(); i++) { + const auto& ctx = child_exprs_lists[0][i]; + data_types.emplace_back(build_not_ignore_null[i] ? make_nullable(ctx->root()->data_type()) : ctx->root()->data_type()); } diff --git a/be/src/pipeline/exec/set_sink_operator.cpp b/be/src/pipeline/exec/set_sink_operator.cpp index 5fc38f3ca706ac..6c76f9a57a3ee2 100644 --- a/be/src/pipeline/exec/set_sink_operator.cpp +++ b/be/src/pipeline/exec/set_sink_operator.cpp @@ -130,9 +130,13 @@ Status SetSinkOperatorX::_extract_build_column( block.get_by_position(result_col_id).column = block.get_by_position(result_col_id).column->convert_to_full_column_if_const(); } + // Do make nullable should not change the origin column and type in origin block + // which may cause coredump problem if (local_state._shared_state->build_not_ignore_null[i]) { - block.get_by_position(result_col_id).column = - make_nullable(block.get_by_position(result_col_id).column); + auto column_ptr = make_nullable(block.get_by_position(result_col_id).column, false); + block.insert( + {column_ptr, make_nullable(block.get_by_position(result_col_id).type), ""}); + result_col_id = block.columns() - 1; } raw_ptrs[i] = block.get_by_position(result_col_id).column.get(); diff --git a/regression-test/data/query_p0/except/test_query_except.out b/regression-test/data/query_p0/except/test_query_except.out index 7aea45fde18a71..763cb44c7f8558 100644 --- a/regression-test/data/query_p0/except/test_query_except.out +++ b/regression-test/data/query_p0/except/test_query_except.out @@ -14,3 +14,5 @@ 14 15 +-- !select_except2 -- + diff --git a/regression-test/suites/query_p0/except/test_query_except.groovy b/regression-test/suites/query_p0/except/test_query_except.groovy index a13fd76e7a91ad..410e24f89b92de 100644 --- a/regression-test/suites/query_p0/except/test_query_except.groovy +++ b/regression-test/suites/query_p0/except/test_query_except.groovy @@ -22,4 +22,7 @@ suite("test_query_except", "arrow_flight_sql") { SELECT * FROM (SELECT k1 FROM test_query_db.baseall EXCEPT SELECT k1 FROM test_query_db.test) a ORDER BY k1 """ + qt_select_except2 """ + select not_null_k1, not_null_k1 from (SELECT non_nullable(k1) as not_null_k1 FROM test_query_db.baseall where k1 is not null) b1 except select non_nullable(k1), k1 from test_query_db.baseall where k1 is not null order by 1, 2; + """ }