Test unused stream in DefaultPluginXmlFactory#write

Author: Vincent Potucek

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java

@@ -59,47 +59,46 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest request) throws XmlReader
         if (inputStream == null && reader == null && path == null && url == null) {
             throw new IllegalArgumentException("path, url, reader or inputStream must be non null");
         }
-        return read(request, inputStream, reader, path, url);
+        return read(request.isAddDefaultEntities(), request.isStrict(), inputStream, reader, path, url);
     }
 
     private static PluginDescriptor read(
-            XmlReaderRequest request, InputStream inputStream, Reader reader, Path path, URL url) {
+            boolean addDefaultEntities, boolean strict, InputStream inputStream, Reader reader, Path path, URL url) {
         try {
             PluginDescriptorStaxReader xml = new PluginDescriptorStaxReader();
-            xml.setAddDefaultEntities(request.isAddDefaultEntities());
+            xml.setAddDefaultEntities(addDefaultEntities);
             if (inputStream != null) {
-                return read(request, xml, inputStream);
+                return read(xml, inputStream, strict);
             } else if (reader != null) {
-                return xml.read(reader, request.isStrict());
+                return xml.read(reader, strict);
             } else if (path != null) {
                 try (InputStream is = Files.newInputStream(path)) {
-                    return read(request, xml, is);
+                    return read(xml, is, strict);
                 }
             }
             try (InputStream is = url.openStream()) {
-                return read(request, xml, is);
+                return read(xml, is, strict);
             }
         } catch (IOException | XMLStreamException e) {
             throw new XmlReaderException("Unable to read plugin: " + getMessage(e), getLocation(e), e);
         }
     }
 
-    private static PluginDescriptor read(XmlReaderRequest request, PluginDescriptorStaxReader xml, InputStream is)
+    private static PluginDescriptor read(PluginDescriptorStaxReader xml, InputStream is, boolean strict)
             throws XMLStreamException {
-        return xml.read(is, request.isStrict());
+        return xml.read(is, strict);
     }
 
     @Override
     public void write(XmlWriterRequest<PluginDescriptor> request) throws XmlWriterException {
         nonNull(request, "request");
-        PluginDescriptor content = nonNull(request.getContent(), "content");
         Path path = request.getPath();
         OutputStream outputStream = request.getOutputStream();
         Writer writer = request.getWriter();
         if (writer == null && outputStream == null && path == null) {
             throw new IllegalArgumentException("writer, output stream, or path must be non null");
         }
-        write(writer, content, outputStream, path);
+        write(writer, request.getContent(), outputStream, path);
     }
 
     private static void write(Writer writer, PluginDescriptor content, OutputStream outputStream, Path path) {