Skip to content

Commit 0a7b041

Browse files
authored
apollo-client-config-data support spring boot 3.0 (#5)
* apollo-client-config-data support spring boot 3.0 * CHANGES.md * AutoConfiguration
1 parent 3940553 commit 0a7b041

File tree

10 files changed

+38
-21
lines changed

10 files changed

+38
-21
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ Apollo Java 2.1.0
1414
* [Add overloaded shortcut method to register BeanDefinition](https://github.com/apolloconfig/apollo/pull/4574)
1515
* [Fix ApolloBootstrapPropertySources precedence issue](https://github.com/apolloconfig/apollo-java/pull/3)
1616
* [Apollo Client Support Spring Boot 3.0](https://github.com/apolloconfig/apollo-java/pull/4)
17+
* [apollo-client-config-data support spring boot 3.0](https://github.com/apolloconfig/apollo-java/pull/5)
1718

1819
------------------
1920
All issues and pull requests are [here](https://github.com/apolloconfig/apollo-java/milestone/1?closed=1)

apollo-client-config-data/src/main/java/com/ctrip/framework/apollo/config/data/extension/initialize/ApolloClientExtensionInitializeFactory.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.springframework.boot.ConfigurableBootstrapContext;
2727
import org.springframework.boot.context.properties.bind.BindHandler;
2828
import org.springframework.boot.context.properties.bind.Binder;
29+
import org.springframework.boot.logging.DeferredLogFactory;
2930

3031
/**
3132
* @author vdisk <[email protected]>
@@ -40,13 +41,15 @@ public class ApolloClientExtensionInitializeFactory {
4041

4142
private final ApolloClientWebsocketExtensionInitializer apolloClientWebsocketExtensionInitializer;
4243

43-
public ApolloClientExtensionInitializeFactory(Log log,
44+
public ApolloClientExtensionInitializeFactory(DeferredLogFactory logFactory,
4445
ConfigurableBootstrapContext bootstrapContext) {
45-
this.log = log;
46+
this.log = logFactory.getLog(ApolloClientExtensionInitializeFactory.class);
4647
this.apolloClientPropertiesFactory = new ApolloClientPropertiesFactory();
47-
this.apolloClientLongPollingExtensionInitializer = new ApolloClientLongPollingExtensionInitializer(log,
48+
this.apolloClientLongPollingExtensionInitializer = new ApolloClientLongPollingExtensionInitializer(
49+
logFactory,
4850
bootstrapContext);
49-
this.apolloClientWebsocketExtensionInitializer = new ApolloClientWebsocketExtensionInitializer(log,
51+
this.apolloClientWebsocketExtensionInitializer = new ApolloClientWebsocketExtensionInitializer(
52+
logFactory,
5053
bootstrapContext);
5154
}
5255

apollo-client-config-data/src/main/java/com/ctrip/framework/apollo/config/data/extension/webclient/ApolloClientLongPollingExtensionInitializer.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.springframework.boot.ConfigurableBootstrapContext;
2828
import org.springframework.boot.context.properties.bind.BindHandler;
2929
import org.springframework.boot.context.properties.bind.Binder;
30+
import org.springframework.boot.logging.DeferredLogFactory;
3031
import org.springframework.boot.web.reactive.function.client.WebClientCustomizer;
3132
import org.springframework.util.CollectionUtils;
3233
import org.springframework.web.reactive.function.client.WebClient;
@@ -41,9 +42,9 @@ public class ApolloClientLongPollingExtensionInitializer implements
4142

4243
private final ConfigurableBootstrapContext bootstrapContext;
4344

44-
public ApolloClientLongPollingExtensionInitializer(Log log,
45+
public ApolloClientLongPollingExtensionInitializer(DeferredLogFactory logFactory,
4546
ConfigurableBootstrapContext bootstrapContext) {
46-
this.log = log;
47+
this.log = logFactory.getLog(ApolloClientLongPollingExtensionInitializer.class);
4748
this.bootstrapContext = bootstrapContext;
4849
}
4950

apollo-client-config-data/src/main/java/com/ctrip/framework/apollo/config/data/extension/websocket/ApolloClientWebsocketExtensionInitializer.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.springframework.boot.ConfigurableBootstrapContext;
2323
import org.springframework.boot.context.properties.bind.BindHandler;
2424
import org.springframework.boot.context.properties.bind.Binder;
25+
import org.springframework.boot.logging.DeferredLogFactory;
2526

2627
/**
2728
* @author vdisk <[email protected]>
@@ -32,9 +33,9 @@ public class ApolloClientWebsocketExtensionInitializer implements ApolloClientEx
3233

3334
private final ConfigurableBootstrapContext bootstrapContext;
3435

35-
public ApolloClientWebsocketExtensionInitializer(Log log,
36+
public ApolloClientWebsocketExtensionInitializer(DeferredLogFactory logFactory,
3637
ConfigurableBootstrapContext bootstrapContext) {
37-
this.log = log;
38+
this.log = logFactory.getLog(ApolloClientWebsocketExtensionInitializer.class);
3839
this.bootstrapContext = bootstrapContext;
3940
}
4041

apollo-client-config-data/src/main/java/com/ctrip/framework/apollo/config/data/importer/ApolloConfigDataLoader.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import org.springframework.boot.context.config.ConfigDataResourceNotFoundException;
3535
import org.springframework.boot.context.properties.bind.BindHandler;
3636
import org.springframework.boot.context.properties.bind.Binder;
37+
import org.springframework.boot.logging.DeferredLogFactory;
3738
import org.springframework.core.Ordered;
3839
import org.springframework.core.env.PropertySource;
3940

@@ -42,10 +43,13 @@
4243
*/
4344
public class ApolloConfigDataLoader implements ConfigDataLoader<ApolloConfigDataResource>, Ordered {
4445

46+
private final DeferredLogFactory logFactory;
47+
4548
private final Log log;
4649

47-
public ApolloConfigDataLoader(Log log) {
48-
this.log = log;
50+
public ApolloConfigDataLoader(DeferredLogFactory logFactory) {
51+
this.logFactory = logFactory;
52+
this.log = logFactory.getLog(ApolloConfigDataLoader.class);
4953
}
5054

5155
@Override
@@ -55,7 +59,7 @@ public ConfigData load(ConfigDataLoaderContext context, ApolloConfigDataResource
5559
Binder binder = bootstrapContext.get(Binder.class);
5660
BindHandler bindHandler = this.getBindHandler(context);
5761
bootstrapContext.registerIfAbsent(ApolloConfigDataLoaderInitializer.class, InstanceSupplier
58-
.from(() -> new ApolloConfigDataLoaderInitializer(this.log, binder, bindHandler,
62+
.from(() -> new ApolloConfigDataLoaderInitializer(this.logFactory, binder, bindHandler,
5963
bootstrapContext)));
6064
ApolloConfigDataLoaderInitializer apolloConfigDataLoaderInitializer = bootstrapContext
6165
.get(ApolloConfigDataLoaderInitializer.class);

apollo-client-config-data/src/main/java/com/ctrip/framework/apollo/config/data/importer/ApolloConfigDataLoaderInitializer.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import org.springframework.boot.context.properties.bind.Bindable;
3636
import org.springframework.boot.context.properties.bind.Binder;
3737
import org.springframework.boot.context.properties.source.ConfigurationPropertyName;
38+
import org.springframework.boot.logging.DeferredLogFactory;
3839
import org.springframework.core.env.MapPropertySource;
3940
import org.springframework.core.env.PropertySource;
4041

@@ -45,6 +46,8 @@ class ApolloConfigDataLoaderInitializer {
4546

4647
private static volatile boolean INITIALIZED = false;
4748

49+
private final DeferredLogFactory logFactory;
50+
4851
private final Log log;
4952

5053
private final Binder binder;
@@ -53,10 +56,11 @@ class ApolloConfigDataLoaderInitializer {
5356

5457
private final ConfigurableBootstrapContext bootstrapContext;
5558

56-
public ApolloConfigDataLoaderInitializer(Log log,
59+
public ApolloConfigDataLoaderInitializer(DeferredLogFactory logFactory,
5760
Binder binder, BindHandler bindHandler,
5861
ConfigurableBootstrapContext bootstrapContext) {
59-
this.log = log;
62+
this.logFactory = logFactory;
63+
this.log = logFactory.getLog(ApolloConfigDataLoaderInitializer.class);
6064
this.binder = binder;
6165
this.bindHandler = bindHandler;
6266
this.bootstrapContext = bootstrapContext;
@@ -98,9 +102,9 @@ public List<PropertySource<?>> initApolloClient() {
98102
}
99103

100104
private void initApolloClientInternal() {
101-
new ApolloClientSystemPropertyInitializer(this.log)
105+
new ApolloClientSystemPropertyInitializer(this.logFactory)
102106
.initializeSystemProperty(this.binder, this.bindHandler);
103-
new ApolloClientExtensionInitializeFactory(this.log,
107+
new ApolloClientExtensionInitializeFactory(this.logFactory,
104108
this.bootstrapContext).initializeExtension(this.binder, this.bindHandler);
105109
DeferredLogger.enable();
106110
ApolloConfigDataInjectorCustomizer.register(ConfigFactory.class,

apollo-client-config-data/src/main/java/com/ctrip/framework/apollo/config/data/importer/ApolloConfigDataLocationResolver.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.springframework.boot.context.config.ConfigDataLocationResolverContext;
2828
import org.springframework.boot.context.config.ConfigDataResourceNotFoundException;
2929
import org.springframework.boot.context.config.Profiles;
30+
import org.springframework.boot.logging.DeferredLogFactory;
3031
import org.springframework.core.Ordered;
3132
import org.springframework.util.StringUtils;
3233

@@ -40,8 +41,8 @@ public class ApolloConfigDataLocationResolver implements
4041

4142
private final Log log;
4243

43-
public ApolloConfigDataLocationResolver(Log log) {
44-
this.log = log;
44+
public ApolloConfigDataLocationResolver(DeferredLogFactory logFactory) {
45+
this.log = logFactory.getLog(ApolloConfigDataLocationResolver.class);
4546
}
4647

4748
@Override

apollo-client-config-data/src/main/java/com/ctrip/framework/apollo/config/data/system/ApolloClientSystemPropertyInitializer.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.springframework.boot.context.properties.bind.BindHandler;
2323
import org.springframework.boot.context.properties.bind.Bindable;
2424
import org.springframework.boot.context.properties.bind.Binder;
25+
import org.springframework.boot.logging.DeferredLogFactory;
2526
import org.springframework.util.StringUtils;
2627

2728
/**
@@ -31,8 +32,8 @@ public class ApolloClientSystemPropertyInitializer {
3132

3233
private final Log log;
3334

34-
public ApolloClientSystemPropertyInitializer(Log log) {
35-
this.log = log;
35+
public ApolloClientSystemPropertyInitializer(DeferredLogFactory logFactory) {
36+
this.log = logFactory.getLog(ApolloClientSystemPropertyInitializer.class);
3637
}
3738

3839
public void initializeSystemProperty(Binder binder, BindHandler bindHandler) {
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
com.ctrip.framework.apollo.config.data.ApolloClientConfigDataAutoConfiguration

apollo-client-config-data/src/test/java/com/ctrip/framework/apollo/config/data/system/ApolloClientSystemPropertyInitializerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import java.util.LinkedHashMap;
2121
import java.util.Map;
2222
import java.util.concurrent.ThreadLocalRandom;
23-
import org.apache.commons.logging.LogFactory;
23+
import java.util.function.Supplier;
2424
import org.junit.After;
2525
import org.junit.Assert;
2626
import org.junit.Test;
@@ -50,7 +50,7 @@ public void testInitializeSystemProperty() {
5050
MapConfigurationPropertySource propertySource = new MapConfigurationPropertySource(map);
5151
Binder binder = new Binder(propertySource);
5252
ApolloClientSystemPropertyInitializer initializer = new ApolloClientSystemPropertyInitializer(
53-
LogFactory.getLog(ApolloClientSystemPropertyInitializerTest.class));
53+
Supplier::get);
5454
initializer.initializeSystemProperty(binder, null);
5555
for (String propertyName : ApolloApplicationContextInitializer.APOLLO_SYSTEM_PROPERTIES) {
5656
Assert.assertEquals(map.get(propertyName), System.getProperty(propertyName));

0 commit comments

Comments
 (0)