Skip to content

Commit 737e550

Browse files
authored
Make NIOSSLContext.configuration public. (#556)
Motivation: It is sometimes useful, such as when converting between configuration formats, to be able to recover the `TLSConfiguration` with which an `NIOSSLContext` was created. This is not possible with the current API; since the property is immutable, making it public poses no risk. Modifications: The `NIOSSLContext.configuration` property is now `public` instead of `internal`. (Also, an extremely obsolete Linux testing note was removed from `CONTRIBUTING.md`.) Result: This change has no functional impact; all behavior remains identical. The only effect is to add the `configuration` property to the public API of `NIOSSLContext`.
1 parent 1d4afc6 commit 737e550

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,6 @@ We require that your commit messages match our template. The easiest way to do t
6363

6464
git config commit.template dev/git.commit.template
6565

66-
### Test on Linux
67-
68-
SwiftNIO uses XCTest to run tests on both macOS and Linux. While the macOS version of XCTest is able to use the Objective-C runtime to discover tests at execution time, the Linux version is not. For this reason, whenever you add new tests you will want to run a script that generates the hooks needed to run those tests on Linux, or our CI will complain that the tests are not all present on Linux. To do this, merely execute `ruby generate_linux_tests.rb` at the root of the package and check the changes it made.
69-
7066
### Run CI checks locally
7167

7268
You can run the Github Actions workflows locally using [act](https://github.com/nektos/act). For detailed steps on how to do this please see [https://github.com/swiftlang/github-workflows?tab=readme-ov-file#running-workflows-locally](https://github.com/swiftlang/github-workflows?tab=readme-ov-file#running-workflows-locally).

Sources/NIOSSL/SSLContext.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ public final class NIOSSLContext {
297297
private var keyLogManager: KeyLogCallbackManager?
298298
internal var pskClientConfigurationCallback: _NIOPSKClientIdentityProvider?
299299
internal var pskServerConfigurationCallback: _NIOPSKServerIdentityProvider?
300-
internal let configuration: TLSConfiguration
300+
public let configuration: TLSConfiguration
301301

302302
/// Initialize a context that will create multiple connections, all with the same
303303
/// configuration.

0 commit comments

Comments
 (0)