Skip to content

Commit 7afea1b

Browse files
authored
fix: skip images without registry in KSV0125 (#428)
Signed-off-by: Nikita Pivkin <[email protected]>
1 parent 7462fa1 commit 7afea1b

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

checks/kubernetes/uses_untrusted_registry.rego

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,21 @@ all_trusted_registires := ksv0125.trusted_registries if {
7777
count(ksv0125.trusted_registries) > 0
7878
} else := default_trusted_registries
7979

80-
container_image_from_trusted_registry(container) if {
80+
container_image_from_untrusted_registry(container) if {
8181
image_parts := split(container.image, "/")
8282
count(image_parts) > 1
8383
registry = image_parts[0]
84+
not is_registry_trusted(registry)
85+
}
86+
87+
is_registry_trusted(registry) if {
8488
some trusted in all_trusted_registires
8589
endswith(registry, trusted)
8690
}
8791

8892
deny contains res if {
8993
some container in kubernetes.containers
90-
not container_image_from_trusted_registry(container)
94+
container_image_from_untrusted_registry(container)
9195
msg := kubernetes.format(sprintf(
9296
"Container %s in %s %s (namespace: %s) uses an image from an untrusted registry.",
9397
[container.name, lower(kubernetes.kind), kubernetes.name, kubernetes.namespace],

checks/kubernetes/uses_untrusted_registry_test.rego

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ test_check_registry[name] if {
1414
"image": "foo.io/test:latest",
1515
"expected": 1,
1616
},
17+
"without registry": {
18+
"image": "test:latest",
19+
"expected": 0,
20+
},
1721
}
1822

1923
inp := {
@@ -44,6 +48,10 @@ test_check_registry_custom_registries[name] if {
4448
"image": "gcr.io/test:latest",
4549
"expected": 1,
4650
},
51+
"without registry": {
52+
"image": "test:latest",
53+
"expected": 0,
54+
},
4755
}
4856

4957
inp := {

0 commit comments

Comments
 (0)