fix(handlers): align response status codes for the verify endpoint (#2016)

james-d-elliott · web-flow · commit c62dbd43d6e6 · 2021-05-21T14:03:44.000+02:00
This aligns all response status codes on the /api/verify endpoint when an error occurs, making it impossible to determine the actual reason for the failure.
diff --git a/internal/handlers/handler_verify.go b/internal/handlers/handler_verify.go
@@ -428,7 +428,9 @@ func VerifyGet(cfg schema.AuthenticationBackendConfiguration) middlewares.Reques
 		targetURL, err := ctx.GetOriginalURL()
 
 		if err != nil {
-			ctx.Error(fmt.Errorf("Unable to parse target URL: %s", err), operationFailedMessage)
+			ctx.Logger.Error(fmt.Errorf("Unable to parse target URL: %s", err))
+			ctx.ReplyUnauthorized()
+
 			return
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -428,7 +428,9 @@ func VerifyGet(cfg schema.AuthenticationBackendConfiguration) middlewares.Reques`
`428`	`428`	`targetURL, err := ctx.GetOriginalURL()`
`429`	`429`
`430`	`430`	`if err != nil {`
`431`		`- ctx.Error(fmt.Errorf("Unable to parse target URL: %s", err), operationFailedMessage)`
	`431`	`+ ctx.Logger.Error(fmt.Errorf("Unable to parse target URL: %s", err))`
	`432`	`+ ctx.ReplyUnauthorized()`
	`433`	`+`
`432`	`434`	`return`
`433`	`435`	`}`
`434`	`436`