Skip to content

feat: run auth triggers on node18 #12479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2023
Merged

feat: run auth triggers on node18 #12479

merged 1 commit into from
Apr 17, 2023

Conversation

sobolk
Copy link
Contributor

@sobolk sobolk commented Apr 17, 2023

Description of changes

This PR:

  • generates new auth trigger functions with node18 runtime and aws sdk v3

Issue #, if available

Description of how you validated changes

Passing E2E tests, except one delete pinpoint test that is also failing on dev.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner April 17, 2023 15:35
@sobolk sobolk merged commit 5fedbaf into aws-amplify:dev Apr 17, 2023
@sobolk sobolk deleted the auth-triggers-node18 branch April 17, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@akshbhu akshbhu akshbhu approved these changes

@pavellazar pavellazar pavellazar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolk @akshbhu @pavellazar