Merge pull request #1078 from patrickjaberg/prj/2024.11.06/fix-frozen-typhoeus-streaming-response

Fix FrozenError in Typhoeus streaming response body

Author: koic

lib/webmock/http_lib_adapters/typhoeus_hydra_adapter.rb

@@ -172,7 +172,7 @@ def self.request_hash(request_signature)
                 request.execute_headers_callbacks(response)
               end
               if request.respond_to?(:streaming?) && request.streaming?
-                response.options[:response_body] = ""
+                response.options[:response_body] = "".dup
                 request.on_body.each { |callback| callback.call(webmock_response.body, response) }
               end
               request.finish(response)

spec/acceptance/typhoeus/typhoeus_hydra_spec.rb

@@ -125,6 +125,19 @@
           expect(test_complete).to eq("")
         end
 
+        it "should initialize the streaming response body with a mutible (non-frozen) string" do
+          skip("This test requires a newer version of Typhoeus") unless @request.respond_to?(:on_body)
+
+          stub_request(:any, "example.com").to_return(body: "body")
+
+          @request.on_body do |body_chunk, response|
+            response.body << body_chunk
+          end
+          hydra.queue @request
+
+          expect{ hydra.run }.not_to raise_error
+        end
+
         it "should call on_headers with 2xx response" do
           body = "on_headers fired"
           stub_request(:any, "example.com").to_return(body: body, headers: {'X-Test' => '1'})