Merge pull request #91 from makeittotop/feat-add-idle-timeout-param

FEAT: Add IDLE_TIMEOUT config param, and update doc.

Author: blind-oracle

README.md

@@ -86,6 +86,10 @@ log_level: warn
 # env: CT_TIMEOUT
 timeout: 10s
 
+# HTTP request idle timeout
+# env: CT_IDLE_TIMEOUT
+idle_timeout: 60s
+
 # Timeout to wait on shutdown to allow load balancers detect that we're going away.
 # During this period after the shutdown command the /alive endpoint will reply with HTTP 503.
 # Set to 0s to disable.

config.go

@@ -22,6 +22,7 @@ type config struct {
 
 	LogLevel          string        `yaml:"log_level" env:"CT_LOG_LEVEL"`
 	Timeout           time.Duration `env:"CT_TIMEOUT"`
+	IdleTimeout       time.Duration `yaml:"idle_timeout" env:"CT_IDLE_TIMEOUT"`
 	TimeoutShutdown   time.Duration `yaml:"timeout_shutdown" env:"CT_TIMEOUT_SHUTDOWN"`
 	Concurrency       int           `env:"CT_CONCURRENCY"`
 	Metadata          bool          `env:"CT_METADATA"`
@@ -89,6 +90,10 @@ func configLoad(file string) (*config, error) {
 		cfg.Timeout = 10 * time.Second
 	}
 
+	if cfg.IdleTimeout == 0 {
+		cfg.IdleTimeout = 60 * time.Second
+	}
+
 	if cfg.Concurrency == 0 {
 		cfg.Concurrency = 512
 	}

deploy/k8s/chart/values.schema.json

@@ -195,6 +195,12 @@
           "description": "HTTP request timeout",
           "format": "duration"
         },
+        "idle_timeout": {
+          "type": "string",
+          "title": "Idle_Timeout",
+          "description": "HTTP request idle timeout",
+          "format": "duration"
+        },
         "timeout_shutdown": {
           "type": "string",
           "title": "Shutdown timeout",

deploy/k8s/chart/values.yaml

@@ -65,6 +65,9 @@ config:
   # -- HTTP request timeout
   # (env: `CT_TIMEOUT`)
   timeout: 10s
+  # -- HTTP request idle timeout
+  # (env: `CT_IDLE_TIMEOUT`)
+  idle_timeout: 60s
   # -- Timeout to wait on shutdown to allow load balancers detect that we're going away.
   # During this period after the shutdown command the /alive endpoint will reply with HTTP 503.
   # Set to 0s to disable.

deploy/k8s/manifests/config-file-configmap.yml

@@ -17,6 +17,8 @@ data:
     log_level: warn
     # HTTP request timeout
     timeout: 10s
+    # HTTP request idle timeout
+    idle_timeout: 60s
     # Timeout to wait on shutdown to allow load balancers detect that we're going away.
     # During this period after the shutdown command the /alive endpoint will reply with HTTP 503.
     # Set to 0s to disable.

processor.go

@@ -97,7 +97,7 @@ func newProcessor(c config) *processor {
 
 		ReadTimeout:  c.Timeout,
 		WriteTimeout: c.Timeout,
-		IdleTimeout:  60 * time.Second,
+		IdleTimeout:  c.IdleTimeout,
 
 		Concurrency: c.Concurrency,
 	}