linters/testifylint: fix windows file issues

Fixes:
	pkg/errmetrics/err_msg_windows_test.go:16:2  testifylint  bool-compare: use assert.True
	pkg/errmetrics/err_msg_windows_test.go:19:2  testifylint  bool-compare: use assert.True
	pkg/ktime/ktime_windows_test.go:16:2         testifylint  negative-positive: use assert.Positive
	pkg/ktime/ktime_windows_test.go:27:2         testifylint  negative-positive: use assert.Positive
	pkg/ktime/ktime_windows_test.go:32:2         testifylint  expected-actual: need to reverse actual and expected values
	pkg/reader/proc/proc_windows_test.go:21:2    testifylint  error-nil: use assert.NoError
	pkg/reader/proc/proc_windows_test.go:31:2    testifylint  error-nil: use assert.NoError
	pkg/reader/proc/proc_windows_test.go:36:2    testifylint  error-nil: use assert.NoError
	pkg/reader/proc/proc_windows_test.go:41:2    testifylint  error-nil: use assert.NoError
	pkg/reader/proc/proc_windows_test.go:46:2    testifylint  error-nil: use assert.NoError
	pkg/reader/proc/proc_windows_test.go:21:2  testifylint  require-error: for error assertions use require
	pkg/reader/proc/proc_windows_test.go:31:2  testifylint  require-error: for error assertions use require
	pkg/reader/proc/proc_windows_test.go:36:2  testifylint  require-error: for error assertions use require
	pkg/reader/proc/proc_windows_test.go:41:2  testifylint  require-error: for error assertions use require
	pkg/reader/proc/proc_windows_test.go:46:2  testifylint  require-error: for error assertions use require

Signed-off-by: Mahe Tardy <[email protected]>

Author: mtardy

pkg/errmetrics/err_msg_windows_test.go

@@ -13,9 +13,9 @@ import (
 
 func TestErrMessage(t *testing.T) {
 	s1 := GetErrorMessage(uint16(syscall.ERROR_ACCESS_DENIED))
-	assert.Equal(t, strings.HasPrefix(s1, "Access is denied."), true)
+	assert.True(t, strings.HasPrefix(s1, "Access is denied."))
 
 	s2 := GetErrorMessage(uint16(syscall.ERROR_INSUFFICIENT_BUFFER))
-	assert.Equal(t, strings.HasPrefix(s2, "The data area passed to a system call is too small."), true)
+	assert.True(t, strings.HasPrefix(s2, "The data area passed to a system call is too small."))
 
 }

pkg/ktime/ktime_windows_test.go

@@ -13,7 +13,7 @@ import (
 func TestKtime(t *testing.T) {
 	time1, err := NanoTimeSince(0)
 	require.NoError(t, err)
-	assert.Greater(t, time1.Milliseconds(), int64(0))
+	assert.Positive(t, time1.Milliseconds())
 	time2, err := NanoTimeSince(0)
 	require.NoError(t, err)
 	assert.GreaterOrEqual(t, time2, time1)
@@ -24,10 +24,10 @@ func TestBoottime(t *testing.T) {
 	require.NoError(t, err)
 	ktime1, err := DecodeKtime(time1.Nanoseconds(), false)
 	require.NoError(t, err)
-	assert.Greater(t, ktime1.UnixMilli(), int64(0))
+	assert.Positive(t, ktime1.UnixMilli())
 }
 
 func TestKernelTime(t *testing.T) {
 	uTime, _ := DecodeKtime(133918958189958838, false)
-	assert.Equal(t, uTime.Unix(), int64(1747422218))
+	assert.Equal(t, int64(1747422218), uTime.Unix())
 }

pkg/reader/proc/proc_windows_test.go

@@ -4,21 +4,20 @@
 package proc
 
 import (
-	"fmt"
 	"os"
 	"syscall"
 	"testing"
 	"unsafe"
 
-	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 	"golang.org/x/sys/windows"
 )
 
 func TestGetProcStatStrings(t *testing.T) {
 	pid := os.Getpid() // Get the current process's PID
 
 	status, err := GetStatus(uint32(pid))
-	assert.Equal(t, err, nil)
+	require.NoError(t, err)
 	t.Log("User = ", status.Uids)
 	t.Log("Group = ", status.Gids)
 	t.Log("LoginUId = ", status.LoginUid)
@@ -28,21 +27,21 @@ func TestFillLoginUid(t *testing.T) {
 	pid := os.Getpid() // Get the current process's PID
 
 	c, err := windows.OpenProcess(windows.PROCESS_QUERY_LIMITED_INFORMATION, false, uint32(pid))
-	assert.Equal(t, err, nil)
+	require.NoError(t, err)
 	defer windows.CloseHandle(c)
 
 	var token syscall.Token
 	err = syscall.OpenProcessToken(syscall.Handle(c), syscall.TOKEN_QUERY, &token)
-	assert.Equal(t, err, nil)
+	require.NoError(t, err)
 	defer token.Close()
 	var logonSid *TokenGroups
 
 	ret, err := getTokenInfo(token, windows.TokenLogonSid, 32)
-	assert.Equal(t, err, nil)
+	require.NoError(t, err)
 	logonSid = (*TokenGroups)(ret)
 	tokenUser := (*syscall.SIDAndAttributes)(unsafe.Pointer(&logonSid.Groups[0]))
 	sid := (*syscall.SID)(unsafe.Pointer(&tokenUser.Sid))
 	str, err1 := sid.String()
-	assert.Equal(t, err1, nil)
-	fmt.Printf("SID = %s", str)
+	require.NoError(t, err1)
+	t.Logf("SID = %s", str)
 }