linters: enable intrange linter

Intrange is a linter to find places where for loops could make use of an
integer range.

Signed-off-by: Mahe Tardy <[email protected]>

Author: mtardy

.golangci.yml

@@ -14,6 +14,7 @@ linters:
     - goheader
     - govet
     - ineffassign
+    - intrange
     - makezero
     - misspell
     - revive

cmd/dump-syscalls-info/main.go

@@ -123,7 +123,7 @@ func dumpSyscalls(fname string) (map[string][]SyscallArg, error) {
 
 		arr := make([]SyscallArg, 0)
 		n := typSym.Size / 8
-		for i := uint64(0); i < n; i++ {
+		for i := range n {
 			typPtr := typSym.Value + (i * 8)
 			typStr, err := ReadString(typPtr)
 			if err != nil {

cmd/tetra/getevents/io_reader_client_test.go

@@ -20,7 +20,7 @@ func Test_ioReaderClient_GetEvents(t *testing.T) {
 	client := newIOReaderClient(events, false)
 	getEventsClient, err := client.GetEvents(context.Background(), &tetragon.GetEventsRequest{})
 	assert.NoError(t, err)
-	for i := 0; i < 3; i++ {
+	for range 3 {
 		_, err := getEventsClient.Recv()
 		assert.NoError(t, err)
 	}

operator/podinfo/podinfo_controller_test.go

@@ -66,7 +66,7 @@ func getRandIP() string {
 func getRandIPs() (string, []string) {
 	length := getRandNum() + 1
 	podIPs := make([]string, length)
-	for i := 0; i < length; i++ {
+	for i := range length {
 		podIPs[i] = getRandIP()
 	}
 	return podIPs[0], podIPs

pkg/bench/trace_bench_open.go

@@ -63,9 +63,7 @@ func (src traceBenchOpen) Run(ctx context.Context, _ *Arguments, _ *Summary) err
 
 	fmt.Printf("threads %v, loops %v, sleep %v(us)\n", *openThreads, *openLoops, *openSleep)
 
-	var i uint
-
-	for i = 0; i < *openThreads; i++ {
+	for range uint(*openThreads) {
 		wg.Add(1)
 		go func() {
 			defer wg.Done()

pkg/bench/trace_bench_rw.go

@@ -107,9 +107,7 @@ func (src traceBenchRw) Run(ctx context.Context, _ *Arguments, _ *Summary) error
 	var wg sync.WaitGroup
 	defer wg.Wait()
 
-	var i uint
-
-	for i = 0; i < *rwThreads; i++ {
+	for range uint(*rwThreads) {
 		wg.Add(1)
 		go func() {
 			defer wg.Done()

pkg/bpf/maps_test.go

@@ -22,7 +22,7 @@ map_extra:      0x0
 memlock:        74056`)
 
 func Benchmark_parseMemlockFromFDInfoReader(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		parseMemlockFromFDInfoReader(mapFDinfo)
 	}
 }

pkg/cgidmap/cri.go

@@ -60,7 +60,7 @@ func (c *criResolver) enqeue(unmappedIDs []unmappedID) {
 	// remove IDs from the end that for which we don't have the capacity
 	newCnt := len(unmappedIDs) + c.unresolvedIDs.Len()
 	if newCnt > maxUnmappedIDs {
-		for i := 0; i < (newCnt - maxUnmappedIDs); i++ {
+		for range newCnt - maxUnmappedIDs {
 			c.unresolvedIDs.Remove(c.unresolvedIDs.Back())
 		}
 	}

pkg/exporter/exporter_test.go

@@ -205,7 +205,7 @@ func Test_rateLimitExport(t *testing.T) {
 				ratelimit.NewRateLimiter(ctx, 50*time.Millisecond, tt.rateLimit, encoder),
 			)
 			assert.NoError(t, exporter.Start(), "exporter must start without errors")
-			for i := 0; i < tt.totalEvents; i++ {
+			for i := range tt.totalEvents {
 				eventNotifier.NotifyListener(nil, &tetragon.GetEventsResponse{
 					Event: &tetragon.GetEventsResponse_ProcessExec{
 						ProcessExec: &tetragon.ProcessExec{Process: &tetragon.Process{Binary: fmt.Sprintf("a%d", i)}},

pkg/fieldfilters/benchmark_test.go

@@ -45,7 +45,7 @@ func (gen *randomEventGenerator) Generate(tb testing.TB) *tetragon.GetEventsResp
 
 func (gen *randomEventGenerator) GenerateN(b *testing.B) []*tetragon.GetEventsResponse {
 	evs := make([]*tetragon.GetEventsResponse, b.N)
-	for i := 0; i < b.N; i++ {
+	for i := range b.N {
 		ev := gen.Generate(b)
 		evs[i] = ev
 	}
@@ -75,7 +75,7 @@ func BenchmarkSerialize(b *testing.B) {
 	evs := gen.GenerateN(b)
 	b.StartTimer()
 
-	for i := 0; i < b.N; i++ {
+	for i := range b.N {
 		ev := evs[i]
 		err := encoder.Encode(ev)
 		assert.NoError(b, err, "event must encode")
@@ -91,7 +91,7 @@ func BenchmarkSerialize_DeepCopy(b *testing.B) {
 	evs := gen.GenerateN(b)
 	b.StartTimer()
 
-	for i := 0; i < b.N; i++ {
+	for i := range b.N {
 		ev := evs[i]
 		ev = proto.Clone(ev).(*tetragon.GetEventsResponse)
 		err := encoder.Encode(ev)
@@ -107,7 +107,7 @@ func BenchmarkSerialize_DeepCopyProcess(b *testing.B) {
 	evs := gen.GenerateN(b)
 	b.StartTimer()
 
-	for i := 0; i < b.N; i++ {
+	for i := range b.N {
 		ev := evs[i]
 		if setter, ok := tetragon.UnwrapGetEventsResponse(ev).(tetragon.ProcessEvent); ok {
 			proc := helpers.ResponseGetProcess(ev)
@@ -130,7 +130,7 @@ func BenchmarkSerialize_FieldFilters(b *testing.B) {
 	require.NoError(b, err)
 	b.StartTimer()
 
-	for i := 0; i < b.N; i++ {
+	for i := range b.N {
 		ev := evs[i]
 		ev, err = ff.Filter(ev)
 		assert.NoError(b, err, "event must filter")
@@ -149,7 +149,7 @@ func BenchmarkSerialize_FieldFilters_NoProcessInfo(b *testing.B) {
 	require.NoError(b, err)
 	b.StartTimer()
 
-	for i := 0; i < b.N; i++ {
+	for i := range b.N {
 		ev := evs[i]
 		ev, err = ff.Filter(ev)
 		assert.NoError(b, err, "event must filter")
@@ -169,7 +169,7 @@ func BenchmarkSerialize_FieldFilters_NoProcesInfoKeepExecid(b *testing.B) {
 	require.NoError(b, err)
 	b.StartTimer()
 
-	for i := 0; i < b.N; i++ {
+	for i := range b.N {
 		ev := evs[i]
 		ev, err = ff.Filter(ev)
 		assert.NoError(b, err, "event must filter")
@@ -189,7 +189,7 @@ func BenchmarkSerialize_RedactionFilters(b *testing.B) {
 	require.NoError(b, err)
 	b.StartTimer()
 
-	for i := 0; i < b.N; i++ {
+	for i := range b.N {
 		ev := evs[i]
 		getProcess, ok := ev.Event.(interface{ GetProcess() *tetragon.Process })
 		if ok {