watcher: Remove unused AddPodInformer function

The pod informer logic has moved to the manager package [^1].

[^1]: #3679

Signed-off-by: Michi Mutsuzaki <[email protected]>

Author: michi-covalent

pkg/process/podinfo_test.go

@@ -5,22 +5,20 @@ package process
 
 import (
 	"testing"
-	"time"
 
 	"github.com/cilium/tetragon/api/v1/tetragon"
 	"github.com/cilium/tetragon/pkg/watcher"
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 	"google.golang.org/protobuf/proto"
 	"google.golang.org/protobuf/types/known/wrapperspb"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/client-go/kubernetes/fake"
 )
 
 func TestK8sWatcher_GetPodInfo(t *testing.T) {
 	controller := true
-	pod := v1.Pod{
+	var pods []interface{}
+	pod := &v1.Pod{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:              "test-pod",
 			Namespace:         "kube-system",
@@ -48,14 +46,11 @@ func TestK8sWatcher_GetPodInfo(t *testing.T) {
 			},
 		},
 	}
+	pods = append(pods, pod)
 
-	k8sClient := fake.NewSimpleClientset(&pod)
-	k8sWatcher := watcher.NewK8sWatcher(k8sClient, nil, time.Hour)
-	err := watcher.AddPodInformer(k8sWatcher, true)
-	require.NoError(t, err)
-	k8sWatcher.Start()
+	podAccessor := watcher.NewFakeK8sWatcher(pods)
 	pid := uint32(1)
-	podInfo := getPodInfo(k8sWatcher, "abcd1234", "curl", "cilium.io", 1)
+	podInfo := getPodInfo(podAccessor, "abcd1234", "curl", "cilium.io", 1)
 	assert.True(t, proto.Equal(podInfo, &tetragon.Pod{
 		Namespace:    pod.Namespace,
 		Workload:     pod.OwnerReferences[0].Name,

pkg/watcher/pod.go

@@ -10,8 +10,6 @@ import (
 
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/client-go/tools/cache"
-
-	"github.com/cilium/tetragon/pkg/podhooks"
 )
 
 const (
@@ -40,39 +38,6 @@ type PodAccessor interface {
 	FindMirrorPod(hash string) (*corev1.Pod, error)
 }
 
-func AddPodInformer(w *K8sWatcher, local bool) error {
-	if w == nil {
-		return errors.New("k8s watcher not initialized")
-	}
-	factory := w.GetK8sInformerFactory()
-	if local {
-		factory = w.GetLocalK8sInformerFactory()
-	}
-	if factory == nil {
-		return errors.New("k8s informer factory not initialized")
-	}
-
-	// initialize deleted pod cache
-	var err error
-	w.deletedPodCache, err = NewDeletedPodCache()
-	if err != nil {
-		return fmt.Errorf("failed to initialize deleted pod cache: %w", err)
-	}
-
-	// add informer to the watcher
-	informer := factory.Core().V1().Pods().Informer()
-	w.AddInformer(podInformerName, informer, map[string]cache.IndexFunc{
-		ContainerIdx: ContainerIndexFunc,
-		PodIdx:       PodIndexFunc,
-	})
-
-	// add event handlers to the informer
-	informer.AddEventHandler(w.deletedPodCache.EventHandler())
-	podhooks.InstallHooks(informer)
-
-	return nil
-}
-
 func ContainerIDKey(contID string) (string, error) {
 	parts := strings.Split(contID, "//")
 	if len(parts) != 2 {