Send empty keyshare extension instead of leaving it out (#163)

bwesterb · web-flow · commit 30869911b666 · 2023-10-10T16:13:10.000+02:00
diff --git a/src/crypto/tls/handshake_messages.go b/src/crypto/tls/handshake_messages.go
@@ -248,7 +248,7 @@ func (m *clientHelloMsg) marshal() ([]byte, error) {
 			})
 		})
 	}
-	if len(m.keyShares) > 0 {
+	if m.keyShares != nil {
 		// RFC 8446, Section 4.2.8
 		exts.AddUint16(extensionKeyShare)
 		exts.AddUint16LengthPrefixed(func(exts *cryptobyte.Builder) {

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ func (m *clientHelloMsg) marshal() ([]byte, error) {`
`248`	`248`	`})`
`249`	`249`	`})`
`250`	`250`	`}`
`251`		`- if len(m.keyShares) > 0 {`
	`251`	`+ if m.keyShares != nil {`
`252`	`252`	`// RFC 8446, Section 4.2.8`
`253`	`253`	`exts.AddUint16(extensionKeyShare)`
`254`	`254`	`exts.AddUint16LengthPrefixed(func(exts *cryptobyte.Builder) {`