Skip to content

Commit dfa81fd

Browse files
V3 Backport [#10515]: fix versions upload positional arg (#10516)
* set script as a positional arg * Update packages/wrangler/src/__tests__/versions/versions.upload.test.ts --------- Co-authored-by: emily-shen <[email protected]> Co-authored-by: emily-shen <[email protected]>
1 parent ab47329 commit dfa81fd

File tree

4 files changed

+34
-2
lines changed

4 files changed

+34
-2
lines changed

.changeset/three-toys-feel.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"wrangler": patch
3+
---
4+
5+
fix: script should be accepted as a positional arg in the `versions upload` command

packages/wrangler/src/__tests__/versions/versions.help.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe("versions --help", () => {
1818
COMMANDS
1919
wrangler versions view <version-id> View the details of a specific version of your Worker
2020
wrangler versions list List the 10 most recent Versions of your Worker
21-
wrangler versions upload Uploads your Worker code and config as a new Version
21+
wrangler versions upload [script] Uploads your Worker code and config as a new Version
2222
wrangler versions deploy [version-specs..] Safely roll out new Versions of your Worker by splitting traffic between multiple Versions
2323
wrangler versions secret Generate a secret that can be referenced in a Worker
2424
@@ -49,7 +49,7 @@ describe("versions subhelp", () => {
4949
COMMANDS
5050
wrangler versions view <version-id> View the details of a specific version of your Worker
5151
wrangler versions list List the 10 most recent Versions of your Worker
52-
wrangler versions upload Uploads your Worker code and config as a new Version
52+
wrangler versions upload [script] Uploads your Worker code and config as a new Version
5353
wrangler versions deploy [version-specs..] Safely roll out new Versions of your Worker by splitting traffic between multiple Versions
5454
wrangler versions secret Generate a secret that can be referenced in a Worker
5555

packages/wrangler/src/__tests__/versions/versions.upload.test.ts

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,32 @@ describe("versions upload", () => {
109109
`);
110110
});
111111

112+
test("should accept script as a positional arg", async () => {
113+
mockGetScript();
114+
mockUploadVersion(false);
115+
116+
// Setup
117+
writeWranglerConfig({
118+
name: "test-name",
119+
// i.e. would error if the arg wasn't picked up
120+
main: "./nope.js",
121+
});
122+
writeWorkerSource();
123+
setIsTTY(false);
124+
125+
const result = runWrangler("versions upload index.js");
126+
127+
await expect(result).resolves.toBeUndefined();
128+
129+
expect(std.out).toMatchInlineSnapshot(`
130+
"Total Upload: xx KiB / gzip: xx KiB
131+
Worker Startup Time: 500 ms
132+
No bindings found.
133+
Uploaded test-name (TIMINGS)
134+
Worker Version ID: 51e4886e-2db7-4900-8d38-fbfecfeab993"
135+
`);
136+
});
137+
112138
test("should print preview url if version has preview", async () => {
113139
mockGetScript();
114140
mockUploadVersion(true);

packages/wrangler/src/versions/upload.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ export const versionsUploadCommand = createCommand({
9696
owner: "Workers: Authoring and Testing",
9797
status: "stable",
9898
},
99+
positionalArgs: ["script"],
99100
args: {
100101
script: {
101102
describe: "The path to an entry point for your Worker",

0 commit comments

Comments
 (0)