Prompt for account xpub imports at wallet creation

This simplifies the provisioning process as these xpubs will now be included
in the address discovery and initial rescan, without manually requiring a RPC
call to add them and rescan again for them.

Author: jrick

internal/prompt/prompt.go

@@ -16,6 +16,7 @@ import (
 
 	"decred.org/dcrwallet/v4/errors"
 	"decred.org/dcrwallet/v4/walletseed"
+	"github.com/decred/dcrd/chaincfg/v3"
 	"github.com/decred/dcrd/hdkeychain/v3"
 	"golang.org/x/term"
 )
@@ -366,6 +367,59 @@ func Seed(reader *bufio.Reader) (seed []byte, imported bool, err error) {
 	}
 }
 
+// ImportedAccounts prompts for any additional account names and xpubs to
+// import at wallet creation.
+func ImportedAccounts(reader *bufio.Reader, params *chaincfg.Params) (names []string, xpubs []*hdkeychain.ExtendedKey, err error) {
+	accounts := make(map[string]struct{})
+	accounts["default"] = struct{}{}
+
+	for {
+		fmt.Printf("Do you have an additional account to import from an " +
+			"extended public key? (enter account name, or 'no') [no]: ")
+		reply, err := reader.ReadString('\n')
+		if err != nil {
+			return nil, nil, err
+		}
+		reply = strings.TrimSpace(reply)
+		switch strings.ToLower(reply) {
+		case "", "n", "no":
+			return names, xpubs, nil
+		case "y", "yes":
+			continue
+		default:
+		}
+
+		account := reply
+		if _, ok := accounts[account]; ok {
+			fmt.Printf("Account %q is already defined\n", account)
+			continue
+		}
+		fmt.Printf("Enter extended public key for account %q: ", account)
+		reply, err = reader.ReadString('\n')
+		if err != nil {
+			if errors.Is(err, io.EOF) {
+				err = io.ErrUnexpectedEOF
+			}
+			return nil, nil, err
+		}
+		reply = strings.TrimSpace(reply)
+		xpub, err := hdkeychain.NewKeyFromString(reply, params)
+		if err != nil {
+			fmt.Printf("Failed to decode extended key: %v\n", err)
+			continue
+		}
+		if xpub.IsPrivate() {
+			fmt.Printf("Extended key is a private key (not neutered)\n")
+			continue
+		}
+
+		fmt.Printf("Importing account %q from extended public key\n", account)
+		names = append(names, account)
+		xpubs = append(xpubs, xpub)
+		accounts[account] = struct{}{}
+	}
+}
+
 // collapseSpace takes a string and replaces any repeated areas of whitespace
 // with a single space character.
 func collapseSpace(in string) string {

walletsetup.go

@@ -9,6 +9,7 @@ import (
 	"bufio"
 	"context"
 	"fmt"
+	"io"
 	"os"
 	"path/filepath"
 	"strings"
@@ -121,6 +122,8 @@ func createWallet(ctx context.Context, cfg *config) error {
 
 	var privPass, pubPass, seed []byte
 	var imported bool
+	var importedAccountNames []string
+	var importedAccountXpubs []*hdkeychain.ExtendedKey
 	var err error
 	c := make(chan struct{}, 1)
 	go func() {
@@ -151,6 +154,23 @@ func createWallet(ctx context.Context, cfg *config) error {
 		// value the user has entered which has already been validated.
 		// There is no config flag to set the seed.
 		seed, imported, err = prompt.Seed(r)
+		if err != nil {
+			return
+		}
+
+		// Additional optional prompts are added after the seed.  If
+		// any of them error reading input with EOF, assume the
+		// default answers.  This allows scripts e.g. the tmux simnet
+		// script which provide scripted input to create wallets to
+		// continue working.
+
+		// Prompt for any additional xpubs to import as watching-only accounts.
+		importedAccountNames, importedAccountXpubs, err = prompt.ImportedAccounts(
+			r, activeNet.Params)
+		if errors.Is(err, io.EOF) {
+			err = nil
+			return
+		}
 	}()
 	select {
 	case <-ctx.Done():
@@ -176,6 +196,15 @@ func createWallet(ctx context.Context, cfg *config) error {
 		}
 	}
 
+	// Import any provided account xpubs
+	for i, name := range importedAccountNames {
+		xpub := importedAccountXpubs[i]
+		err := w.ImportXpubAccount(ctx, name, xpub)
+		if err != nil {
+			return err
+		}
+	}
+
 	// Display a mining address when creating a simnet wallet.
 	if cfg.SimNet {
 		err := displaySimnetMiningAddrs(seed, imported)