linter: fixes

Author: dajohi

.github/workflows/go.yml

@@ -16,7 +16,7 @@ jobs:
         with:
           go-version: ${{ matrix.go }}
       - name: Check out source
-        uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c #v3.3.0
+        uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3 #v3.5.0
       - name: Build
         run: go build ./...
       - name: Test

p2p/peering.go

@@ -1653,7 +1653,6 @@ func (rp *RemotePeer) HeadersAsync(ctx context.Context, blockLocators []*chainha
 			stalled.Stop()
 			return rp.err
 		case out <- &msgAck{m, nil}:
-			out = nil
 			return nil
 		}
 	}

rpc/client/dcrd/calls.go

@@ -96,7 +96,10 @@ func (r *RPC) ExistsLiveTicket(ctx context.Context, ticket *chainhash.Hash) (boo
 func (r *RPC) ExistsLiveExpiredTickets(ctx context.Context, tickets []*chainhash.Hash) (live, _ bitset.Bytes, err error) {
 	const op errors.Op = "dcrd.ExistsLiveExpiredTickets"
 	// Reuse the single json.RawMessage for both calls
-	ticketArray, _ := json.Marshal(hashSliceToStrings(tickets))
+	ticketArray, err := json.Marshal(hashSliceToStrings(tickets))
+	if err != nil {
+		return nil, nil, err
+	}
 	errs := make(chan error, 1)
 	go func() { errs <- exists(ctx, r, "existslivetickets", &live, ticketArray) }()
 	for i := 0; i < cap(errs); i++ {
@@ -124,9 +127,12 @@ func (r *RPC) ExistsExpiredMissedTickets(ctx context.Context, tickets []*chainha
 // existsaddress index to be enabled.
 func (r *RPC) UsedAddresses(ctx context.Context, addrs []stdaddr.Address) (bitset.Bytes, error) {
 	const op errors.Op = "dcrd.UsedAddresses"
-	addrArray, _ := json.Marshal(addrSliceToStrings(addrs))
+	addrArray, err := json.Marshal(addrSliceToStrings(addrs))
+	if err != nil {
+		return nil, errors.E(op, err)
+	}
 	var bits bitset.Bytes
-	err := exists(ctx, r, "existsaddresses", &bits, addrArray)
+	err = exists(ctx, r, "existsaddresses", &bits, addrArray)
 	if err != nil {
 		return nil, errors.E(op, err)
 	}
@@ -137,9 +143,12 @@ func (r *RPC) UsedAddresses(ctx context.Context, addrs []stdaddr.Address) (bitse
 // currently live.
 func (r *RPC) ExistsLiveTickets(ctx context.Context, tickets []*chainhash.Hash) (bitset.Bytes, error) {
 	const op errors.Op = "dcrd.ExistsLiveTickets"
-	ticketArray, _ := json.Marshal(hashSliceToStrings(tickets))
+	ticketArray, err := json.Marshal(hashSliceToStrings(tickets))
+	if err != nil {
+		return nil, errors.E(op, err)
+	}
 	var bits bitset.Bytes
-	err := exists(ctx, r, "existslivetickets", &bits, ticketArray)
+	err = exists(ctx, r, "existslivetickets", &bits, ticketArray)
 	if err != nil {
 		return nil, errors.E(op, err)
 	}

wallet/addresses.go

@@ -691,75 +691,6 @@ func (w *Wallet) AddressAtIdx(ctx context.Context, account, branch,
 	return addr, nil
 }
 
-func (w *Wallet) nextImportedXpubAddress(ctx context.Context, op errors.Op,
-	maybeDBTX walletdb.ReadWriteTx, accountName string, account uint32, branch uint32,
-	callOpts ...NextAddressCallOption) (addr stdaddr.Address, err error) {
-
-	dbtx := maybeDBTX
-	if dbtx == nil {
-		dbtx, err = w.db.BeginReadWriteTx()
-		if err != nil {
-			return nil, err
-		}
-		defer func() {
-			if err == nil {
-				err = dbtx.Commit()
-			} else {
-				dbtx.Rollback()
-			}
-		}()
-	}
-
-	ns := dbtx.ReadWriteBucket(waddrmgrNamespaceKey)
-	xpub, err := w.manager.AccountExtendedPubKey(dbtx, account)
-	if err != nil {
-		return nil, errors.E(op, err)
-	}
-	props, err := w.manager.AccountProperties(ns, account)
-	branchKey, err := xpub.Child(branch)
-	if err != nil {
-		return nil, errors.E(op, err)
-	}
-	var childKey *hdkeychain.ExtendedKey
-	var child uint32
-	switch branch {
-	case 0:
-		child = props.LastReturnedExternalIndex + 1
-	case 1:
-		child = props.LastReturnedInternalIndex + 1
-	default:
-		return nil, errors.E(op, "branch is required to be 0 or 1")
-	}
-	for {
-		childKey, err = branchKey.Child(child)
-		if err == hdkeychain.ErrInvalidChild {
-			child++
-			continue
-		}
-		if err != nil {
-			return nil, errors.E(op, err)
-		}
-		break
-	}
-	pkh := dcrutil.Hash160(childKey.SerializedPubKey())
-	apkh, err := stdaddr.NewAddressPubKeyHashEcdsaSecp256k1V0(pkh, w.chainParams)
-	if err != nil {
-		return nil, errors.E(op, err)
-	}
-	addr = &xpubAddress{
-		AddressPubKeyHashEcdsaSecp256k1V0: apkh,
-		xpub:                              xpub,
-		account:                           account,
-		branch:                            branch,
-		child:                             child,
-	}
-	err = w.manager.MarkReturnedChildIndex(dbtx, account, branch, child)
-	if err != nil {
-		return nil, errors.E(op, err)
-	}
-	return addr, nil
-}
-
 func minUint32(a, b uint32) uint32 {
 	if a < b {
 		return a

wallet/mixing_test.go

@@ -19,6 +19,7 @@ func MsgTxFromHex(hexTx string) (*wire.MsgTx, error) {
 }
 
 func TestIsMixTx(t *testing.T) {
+	t.Parallel()
 
 	// 11x 2.68435456
 	tx0, err := MsgTxFromHex(mix0Hex)

wallet/udb/addressdb.go

@@ -72,9 +72,6 @@ type dbBIP0044AccountRow struct {
 	lastReturnedExternalIndex uint32 // Added in version 5
 	lastReturnedInternalIndex uint32 // Added in version 5
 	name                      string
-
-	// variables subbucket is used to record remaining fields
-	uniqueKey *kdf.Argon2idParams
 }
 
 func (r *dbBIP0044AccountRow) accountType() accountType { return actBIP0044Legacy }

wallet/udb/txdb.go

@@ -1667,10 +1667,6 @@ func (it *unminedCreditIterator) next() bool {
 // 	return nil
 // }
 
-func (it *unminedCreditIterator) reposition(txHash *chainhash.Hash, index uint32) {
-	it.c.Seek(canonicalOutPoint(txHash, index))
-}
-
 func (it *unminedCreditIterator) close() {
 	if it.c == nil {
 		return

wallet/udb/upgrades_test.go

@@ -44,8 +44,6 @@ var dbUpgradeTests = [...]struct {
 var pubPass = []byte("public")
 
 func TestUpgrades(t *testing.T) {
-	t.Parallel()
-
 	ctx := context.Background()
 	d, err := os.MkdirTemp("", "dcrwallet_udb_TestUpgrades")
 	if err != nil {