From ad0bceba15a1befaa29fcad66d3c71b1b83b135f Mon Sep 17 00:00:00 2001 From: Adam Sitnik Date: Fri, 29 Aug 2025 17:26:56 +0200 Subject: [PATCH 1/2] add notes based on Threat Model review --- docs/standard/commandline/how-to-configure-the-parser.md | 2 ++ docs/standard/commandline/syntax.md | 2 ++ 2 files changed, 4 insertions(+) diff --git a/docs/standard/commandline/how-to-configure-the-parser.md b/docs/standard/commandline/how-to-configure-the-parser.md index 0b01feda21dea..6923e26668e38 100644 --- a/docs/standard/commandline/how-to-configure-the-parser.md +++ b/docs/standard/commandline/how-to-configure-the-parser.md @@ -31,6 +31,8 @@ They are exposed by the property to `null`. You can also provide a custom implementation to customize how response files are processed. +Response file can contain other response file names, hence parsing may include opening other files. The library expects that all response files were generated and stored by trust worthy agent(s). + ## InvocationConfiguration ### Standard output and error diff --git a/docs/standard/commandline/syntax.md b/docs/standard/commandline/syntax.md index 652eae52866ca..2f2dae4300e9a 100644 --- a/docs/standard/commandline/syntax.md +++ b/docs/standard/commandline/syntax.md @@ -43,6 +43,8 @@ A token can contain spaces if it's enclosed in quotation marks (`"`). Here's an dotnet tool search "ef migrations add" ``` +The symbol hierarchy (commands, options, arguments) is considered to be trusted input, the token values are not. + ## Commands A *command* in command-line input is a token that specifies an action or defines a group of related actions. For example: From 2755b5cf2db6f87af623595ebb7d4c57e2347ca5 Mon Sep 17 00:00:00 2001 From: Adam Sitnik Date: Wed, 10 Sep 2025 16:45:00 +0200 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- docs/standard/commandline/how-to-configure-the-parser.md | 2 +- docs/standard/commandline/syntax.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/standard/commandline/how-to-configure-the-parser.md b/docs/standard/commandline/how-to-configure-the-parser.md index 6923e26668e38..cfa2a49229a3d 100644 --- a/docs/standard/commandline/how-to-configure-the-parser.md +++ b/docs/standard/commandline/how-to-configure-the-parser.md @@ -31,7 +31,7 @@ They are exposed by the property to `null`. You can also provide a custom implementation to customize how response files are processed. -Response file can contain other response file names, hence parsing may include opening other files. The library expects that all response files were generated and stored by trust worthy agent(s). +Response file can contain other response file names, hence parsing might include opening other files. The library expects that all response files were generated and stored by trustworthy agents. ## InvocationConfiguration diff --git a/docs/standard/commandline/syntax.md b/docs/standard/commandline/syntax.md index 2f2dae4300e9a..ff66a446af68c 100644 --- a/docs/standard/commandline/syntax.md +++ b/docs/standard/commandline/syntax.md @@ -43,7 +43,7 @@ A token can contain spaces if it's enclosed in quotation marks (`"`). Here's an dotnet tool search "ef migrations add" ``` -The symbol hierarchy (commands, options, arguments) is considered to be trusted input, the token values are not. +The symbol hierarchy (commands, options, arguments) is considered to be trusted input; the token values are not. ## Commands