PR Feedback

Author: jander-msft

src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/AuthenticationTests.cs

@@ -13,6 +13,7 @@
 using Microsoft.IdentityModel.Tokens;
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.IdentityModel.Tokens.Jwt;
 using System.Net;
 using System.Net.Http;
@@ -824,7 +825,7 @@ private static JwtPayload GetJwtPayload(string audience, string subject, string
             if (expiration.HasValue)
             {
                 long expirationSecondsSinceEpoch = EpochTime.GetIntDate(expiration.Value);
-                Claim expClaim = new Claim(AuthConstants.ClaimExpirationStr, expirationSecondsSinceEpoch.ToString());
+                Claim expClaim = new Claim(AuthConstants.ClaimExpirationStr, expirationSecondsSinceEpoch.ToString(CultureInfo.InvariantCulture));
                 claims.Add(expClaim);
             }
 

src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/Options/OptionsExtensions.ApiKey.cs

@@ -6,6 +6,7 @@
 using Microsoft.Diagnostics.Tools.Monitor;
 using Microsoft.IdentityModel.Tokens;
 using System;
+using System.Globalization;
 using System.IdentityModel.Tokens.Jwt;
 using System.Security.Claims;
 
@@ -21,7 +22,7 @@ public static RootOptions UseApiKey(this RootOptions options, string algorithmNa
             string subjectStr = subject.ToString("D");
             Claim audClaim = new Claim(AuthConstants.ClaimAudienceStr, AuthConstants.ApiKeyJwtAudience);
             long expirationSecondsSinceEpoch = EpochTime.GetIntDate(DateTime.UtcNow + AuthConstants.ApiKeyJwtDefaultExpiration);
-            Claim expClaim = new Claim(AuthConstants.ClaimExpirationStr, expirationSecondsSinceEpoch.ToString());
+            Claim expClaim = new Claim(AuthConstants.ClaimExpirationStr, expirationSecondsSinceEpoch.ToString(CultureInfo.InvariantCulture));
             Claim issClaim = new Claim(AuthConstants.ClaimIssuerStr, AuthConstants.ApiKeyJwtInternalIssuer);
             Claim subClaim = new Claim(AuthConstants.ClaimSubjectStr, subjectStr);
             JwtPayload newPayload = new JwtPayload(new Claim[] { audClaim, expClaim, issClaim, subClaim });

src/Tools/dotnet-monitor/Strings.Designer.cs

@@ -946,7 +946,7 @@
     <value>The expiration offset must be a positive time span value.</value>
   </data>
   <data name="HelpDescription_Expiration" xml:space="preserve">
-    <value>The expiration time on or after the generated key will no longer be accepted. This is a time span offset (e.g. "1:00:00" for one-hour) that will be added to the current date time to create the expiration date time.</value>
+    <value>The expiration time on or after the generated key will no longer be accepted. This is a time span offset (e.g. "7.00:00:00" for 7 days) that will be added to the current date time to create the expiration date time.</value>
     <comment>Gets the string to display in help that explains what the '--expiration' option does.</comment>
   </data>
 </root>