Skip to content

Commit e234833

Browse files
authored
chore: move RdImpl functions together (#1694)
No functional changes are made. Signed-off-by: Roman Gershman <[email protected]>
1 parent a743d75 commit e234833

File tree

1 file changed

+50
-50
lines changed

1 file changed

+50
-50
lines changed

src/core/sorted_map.cc

Lines changed: 50 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -158,34 +158,6 @@ optional<double> SortedMap::RdImpl::GetScore(sds member) const {
158158
return *(double*)dictGetVal(de);
159159
}
160160

161-
int SortedMap::DfImpl::Add(double score, sds ele, int in_flags, int* out_flags, double* newscore) {
162-
LOG(FATAL) << "TBD";
163-
return 0;
164-
}
165-
166-
optional<double> SortedMap::DfImpl::GetScore(sds ele) const {
167-
LOG(FATAL) << "TBD";
168-
return std::nullopt;
169-
}
170-
171-
void SortedMap::DfImpl::Init() {
172-
LOG(FATAL) << "TBD";
173-
}
174-
175-
void SortedMap::DfImpl::Free() {
176-
LOG(FATAL) << "TBD";
177-
}
178-
179-
bool SortedMap::DfImpl::Insert(double score, sds member) {
180-
LOG(FATAL) << "TBD";
181-
return false;
182-
}
183-
184-
optional<unsigned> SortedMap::DfImpl::GetRank(sds ele, bool reverse) const {
185-
LOG(FATAL) << "TBD";
186-
return std::nullopt;
187-
}
188-
189161
SortedMap::ScoredArray SortedMap::RdImpl::GetRange(const zrangespec& range, unsigned offset,
190162
unsigned limit, bool reverse) const {
191163
/* If reversed, get the last node in range as starting point. */
@@ -217,12 +189,6 @@ SortedMap::ScoredArray SortedMap::RdImpl::GetRange(const zrangespec& range, unsi
217189
return result;
218190
}
219191

220-
SortedMap::ScoredArray SortedMap::DfImpl::GetRange(const zrangespec& range, unsigned offset,
221-
unsigned limit, bool reverse) const {
222-
LOG(FATAL) << "TBD";
223-
return {};
224-
}
225-
226192
SortedMap::ScoredArray SortedMap::RdImpl::GetLexRange(const zlexrangespec& range, unsigned offset,
227193
unsigned limit, bool reverse) const {
228194
zskiplistNode* ln;
@@ -259,12 +225,6 @@ SortedMap::ScoredArray SortedMap::RdImpl::GetLexRange(const zlexrangespec& range
259225
return result;
260226
}
261227

262-
SortedMap::ScoredArray SortedMap::DfImpl::GetLexRange(const zlexrangespec& range, unsigned offset,
263-
unsigned limit, bool reverse) const {
264-
LOG(FATAL) << "TBD";
265-
return {};
266-
}
267-
268228
uint8_t* SortedMap::RdImpl::ToListPack() const {
269229
uint8_t* lp = lpNew(0);
270230

@@ -280,11 +240,6 @@ uint8_t* SortedMap::RdImpl::ToListPack() const {
280240
return lp;
281241
}
282242

283-
uint8_t* SortedMap::DfImpl::ToListPack() const {
284-
LOG(FATAL) << "TBD";
285-
return nullptr;
286-
}
287-
288243
bool SortedMap::RdImpl::Delete(sds member) {
289244
dictEntry* de = dictUnlink(dict, member);
290245
if (de == NULL)
@@ -309,11 +264,6 @@ bool SortedMap::RdImpl::Delete(sds member) {
309264
return true;
310265
}
311266

312-
bool SortedMap::DfImpl::Delete(sds ele) {
313-
LOG(FATAL) << "TBD";
314-
return false;
315-
}
316-
317267
SortedMap::ScoredArray SortedMap::RdImpl::PopTopScores(unsigned count, bool reverse) {
318268
zskiplistNode* ln;
319269
if (reverse) {
@@ -406,6 +356,56 @@ bool SortedMap::RdImpl::Iterate(unsigned start_rank, unsigned len, bool reverse,
406356
return success;
407357
}
408358

359+
int SortedMap::DfImpl::Add(double score, sds ele, int in_flags, int* out_flags, double* newscore) {
360+
LOG(FATAL) << "TBD";
361+
return 0;
362+
}
363+
364+
optional<double> SortedMap::DfImpl::GetScore(sds ele) const {
365+
LOG(FATAL) << "TBD";
366+
return std::nullopt;
367+
}
368+
369+
void SortedMap::DfImpl::Init() {
370+
LOG(FATAL) << "TBD";
371+
}
372+
373+
void SortedMap::DfImpl::Free() {
374+
LOG(FATAL) << "TBD";
375+
}
376+
377+
bool SortedMap::DfImpl::Insert(double score, sds member) {
378+
LOG(FATAL) << "TBD";
379+
return false;
380+
}
381+
382+
optional<unsigned> SortedMap::DfImpl::GetRank(sds ele, bool reverse) const {
383+
LOG(FATAL) << "TBD";
384+
return std::nullopt;
385+
}
386+
387+
SortedMap::ScoredArray SortedMap::DfImpl::GetRange(const zrangespec& range, unsigned offset,
388+
unsigned limit, bool reverse) const {
389+
LOG(FATAL) << "TBD";
390+
return {};
391+
}
392+
393+
SortedMap::ScoredArray SortedMap::DfImpl::GetLexRange(const zlexrangespec& range, unsigned offset,
394+
unsigned limit, bool reverse) const {
395+
LOG(FATAL) << "TBD";
396+
return {};
397+
}
398+
399+
uint8_t* SortedMap::DfImpl::ToListPack() const {
400+
LOG(FATAL) << "TBD";
401+
return nullptr;
402+
}
403+
404+
bool SortedMap::DfImpl::Delete(sds ele) {
405+
LOG(FATAL) << "TBD";
406+
return false;
407+
}
408+
409409
SortedMap::ScoredArray SortedMap::DfImpl::PopTopScores(unsigned count, bool reverse) {
410410
LOG(FATAL) << "TBD";
411411
return {};

0 commit comments

Comments
 (0)