Skip to content

Commit 760f66e

Browse files
mnonnenmachersschuberth
authored andcommitted
deps: update org.ossreviewtoolkit:version-catalog to v67
This ORT major release contains two breaking changes which require changes: * The introduction of the new `LicenseFactProvider` plugins allows to simplify the custom implementation that reads license texts from the config directory. * The `Environment.toolVersion` property and related database tables need to be removed.
1 parent bd3754f commit 760f66e

File tree

27 files changed

+190
-387
lines changed

27 files changed

+190
-387
lines changed

core/src/test/kotlin/api/RunsRouteIntegrationTest.kt

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -894,8 +894,7 @@ class RunsRouteIntegrationTest : AbstractIntegrationTest({
894894
os = "Linux",
895895
processors = 8,
896896
maxMemory = 8321499136,
897-
variables = emptyMap(),
898-
toolVersions = emptyMap()
897+
variables = emptyMap()
899898
),
900899
config = AnalyzerConfiguration(
901900
allowDynamicVersions = true,
@@ -992,8 +991,7 @@ class RunsRouteIntegrationTest : AbstractIntegrationTest({
992991
os = "Linux",
993992
processors = 8,
994993
maxMemory = 8321499136,
995-
variables = emptyMap(),
996-
toolVersions = emptyMap()
994+
variables = emptyMap()
997995
),
998996
config = AdvisorConfiguration(
999997
config = mapOf(
@@ -1098,8 +1096,7 @@ class RunsRouteIntegrationTest : AbstractIntegrationTest({
10981096
os = "Linux",
10991097
processors = 8,
11001098
maxMemory = 8321499136,
1101-
variables = emptyMap(),
1102-
toolVersions = emptyMap()
1099+
variables = emptyMap()
11031100
),
11041101
config = AnalyzerConfiguration(
11051102
allowDynamicVersions = true,
@@ -1412,8 +1409,7 @@ class RunsRouteIntegrationTest : AbstractIntegrationTest({
14121409
os = "Linux",
14131410
processors = 8,
14141411
maxMemory = 8321499136,
1415-
variables = emptyMap(),
1416-
toolVersions = emptyMap()
1412+
variables = emptyMap()
14171413
),
14181414
config = AnalyzerConfiguration(
14191415
allowDynamicVersions = true,
@@ -1882,8 +1878,7 @@ class RunsRouteIntegrationTest : AbstractIntegrationTest({
18821878
os = "Linux",
18831879
processors = 8,
18841880
maxMemory = 8321499136,
1885-
variables = emptyMap(),
1886-
toolVersions = emptyMap()
1881+
variables = emptyMap()
18871882
),
18881883
config = AnalyzerConfiguration(
18891884
allowDynamicVersions = true,
@@ -2002,8 +1997,7 @@ class RunsRouteIntegrationTest : AbstractIntegrationTest({
20021997
os = "Linux",
20031998
processors = 8,
20041999
maxMemory = 8321499136,
2005-
variables = emptyMap(),
2006-
toolVersions = emptyMap()
2000+
variables = emptyMap()
20072001
),
20082002
config = AdvisorConfiguration(
20092003
config = mapOf(
@@ -2320,8 +2314,7 @@ private fun generateAdvisorEnvironment() = Environment(
23202314
os = "Linux",
23212315
processors = 8,
23222316
maxMemory = 8321499136,
2323-
variables = emptyMap(),
2324-
toolVersions = emptyMap()
2317+
variables = emptyMap()
23252318
)
23262319

23272320
private fun generateAdvisorConfiguration() = AdvisorConfiguration(

dao/src/main/kotlin/queries/environment/GetEnvironmentQuery.kt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ package org.eclipse.apoapsis.ortserver.dao.queries.environment
2121

2222
import org.eclipse.apoapsis.ortserver.dao.Query
2323
import org.eclipse.apoapsis.ortserver.dao.tables.shared.EnvironmentsTable
24-
import org.eclipse.apoapsis.ortserver.dao.tables.shared.EnvironmentsToolVersionsTable
2524
import org.eclipse.apoapsis.ortserver.dao.tables.shared.EnvironmentsVariablesTable
26-
import org.eclipse.apoapsis.ortserver.dao.tables.shared.ToolVersionsTable
2725
import org.eclipse.apoapsis.ortserver.dao.tables.shared.VariablesTable
2826
import org.eclipse.apoapsis.ortserver.model.runs.Environment
2927

@@ -39,13 +37,6 @@ class GetEnvironmentQuery(
3937

4038
if (resultRow == null) return null
4139

42-
val toolVersions = EnvironmentsToolVersionsTable
43-
.innerJoin(ToolVersionsTable)
44-
.select(ToolVersionsTable.name, ToolVersionsTable.version)
45-
.where { EnvironmentsToolVersionsTable.environmentId eq environmentId }.associate {
46-
it[ToolVersionsTable.name] to it[ToolVersionsTable.version]
47-
}
48-
4940
val variables = EnvironmentsVariablesTable
5041
.innerJoin(VariablesTable)
5142
.select(VariablesTable.name, VariablesTable.value)
@@ -59,8 +50,7 @@ class GetEnvironmentQuery(
5950
os = resultRow[EnvironmentsTable.os],
6051
processors = resultRow[EnvironmentsTable.processors],
6152
maxMemory = resultRow[EnvironmentsTable.maxMemory],
62-
variables = variables,
63-
toolVersions = toolVersions
53+
variables = variables
6454
)
6555
}
6656
}

dao/src/main/kotlin/tables/shared/EnvironmentsTable.kt

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ class EnvironmentDao(id: EntityID<Long>) : LongEntity(id) {
5050
(EnvironmentsTable.processors eq environment.processors) and
5151
(EnvironmentsTable.maxMemory eq environment.maxMemory)
5252
}.firstOrNull { dao ->
53-
dao.variables.associate { it.name to it.value } == environment.variables &&
54-
dao.toolVersions.associate { it.name to it.version } == environment.toolVersions
53+
dao.variables.associate { it.name to it.value } == environment.variables
5554
}
5655

5756
fun getOrPut(environment: Environment): EnvironmentDao =
@@ -62,15 +61,6 @@ class EnvironmentDao(id: EntityID<Long>) : LongEntity(id) {
6261
processors = environment.processors
6362
maxMemory = environment.maxMemory
6463
}.also { environmentDao ->
65-
environment.toolVersions.forEach { (name, version) ->
66-
val toolVersionDao = ToolVersionDao.getOrPut(name, version)
67-
68-
EnvironmentsToolVersionsTable.insert {
69-
it[environmentId] = environmentDao.id
70-
it[toolVersionId] = toolVersionDao.id
71-
}
72-
}
73-
7464
environment.variables.forEach { (name, value) ->
7565
val variableDao = VariableDao.getOrPut(name, value)
7666

@@ -89,15 +79,13 @@ class EnvironmentDao(id: EntityID<Long>) : LongEntity(id) {
8979
var maxMemory by EnvironmentsTable.maxMemory
9080

9181
val variables by VariableDao via EnvironmentsVariablesTable
92-
val toolVersions by ToolVersionDao via EnvironmentsToolVersionsTable
9382

9483
fun mapToModel() = Environment(
9584
ortVersion = ortVersion,
9685
javaVersion = javaVersion,
9786
os = os,
9887
processors = processors,
9988
maxMemory = maxMemory,
100-
variables = variables.associate { it.name to it.value },
101-
toolVersions = toolVersions.associate { it.name to it.version }
89+
variables = variables.associate { it.name to it.value }
10290
)
10391
}

dao/src/main/kotlin/tables/shared/EnvironmentsToolVersionsTable.kt

Lines changed: 0 additions & 33 deletions
This file was deleted.

dao/src/main/kotlin/tables/shared/ToolVersionsTable.kt

Lines changed: 0 additions & 52 deletions
This file was deleted.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
-- Remove the tool versions because they have been removed in ORT.
2+
DROP TABLE environments_tool_versions;
3+
DROP TABLE tool_versions;

dao/src/test/kotlin/migrations/V73__deduplicatePackagesAndProjectsTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,7 @@ private val environment = Environment(
343343
os = "testOS",
344344
processors = 2,
345345
maxMemory = 16384,
346-
variables = emptyMap(),
347-
toolVersions = emptyMap()
346+
variables = emptyMap()
348347
)
349348

350349
private val baseIdentifier = Identifier("test", "ns", "name", "1.0")

dao/src/test/kotlin/repositories/advisorrun/DaoAdvisorRunRepositoryTest.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -117,19 +117,13 @@ private val variables = mapOf(
117117
"TERM" to "xterm-256color"
118118
)
119119

120-
private val toolVersions = mapOf(
121-
"Conan" to "1.53.0",
122-
"NPM" to "8.15.1"
123-
)
124-
125120
private val environment = Environment(
126121
ortVersion = "1.0",
127122
javaVersion = "11.0.16",
128123
os = "Linux",
129124
processors = 8,
130125
maxMemory = 8321499136,
131-
variables = variables,
132-
toolVersions = toolVersions
126+
variables = variables
133127
)
134128

135129
private val advisorConfiguration = AdvisorConfiguration(

dao/src/test/kotlin/repositories/analyzerrun/DaoAnalyzerRunRepositoryTest.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -368,19 +368,13 @@ private val variables = mapOf(
368368
"TERM" to "xterm-256color"
369369
)
370370

371-
private val toolVersions = mapOf(
372-
"Conan" to "1.53.0",
373-
"NPM" to "8.15.1"
374-
)
375-
376371
private val environment = Environment(
377372
ortVersion = "1.0",
378373
javaVersion = "11.0.16",
379374
os = "Linux",
380375
processors = 8,
381376
maxMemory = 8321499136,
382-
variables = variables,
383-
toolVersions = toolVersions
377+
variables = variables
384378
)
385379

386380
private val identifier = Identifier(

dao/src/test/kotlin/repositories/scannerrun/DaoScannerRunRepositoryTest.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -398,19 +398,13 @@ private val variables = mapOf(
398398
"TERM" to "xterm-256color"
399399
)
400400

401-
private val toolVersions = mapOf(
402-
"Conan" to "1.53.0",
403-
"NPM" to "8.15.1"
404-
)
405-
406401
private val environment = Environment(
407402
ortVersion = "1.0",
408403
javaVersion = "11.0.16",
409404
os = "Linux",
410405
processors = 8,
411406
maxMemory = 8321499136,
412-
variables = variables,
413-
toolVersions = toolVersions
407+
variables = variables
414408
)
415409

416410
private val scannerRun = ScannerRun(

0 commit comments

Comments
 (0)