|
34 | 34 | <FileSignInfo Include="comhost.dll" CertificateName="None" />
|
35 | 35 | <FileSignInfo Include="singlefilehost.exe" CertificateName="None" />
|
36 | 36 |
|
37 |
| - <!-- .ttf and .js files come in from some older aspnetcore packages (e.g. 2.1). |
| 37 | + <!-- .ttf and .otf files come in from some older aspnetcore packages (e.g. 2.1). |
38 | 38 | These files in the 5.0 packages are NOT signed. When doing postbuild signing,
|
39 | 39 | SignTool will recognize that the files in the installer zips came from the 5.0 packages
|
40 | 40 | pulled in from aspnetcore, and aspnetcore said not to sign them. This info is not
|
41 | 41 | available for the 2.1 packages, so we need to avoid signing these in this repo. -->
|
42 | 42 | <FileExtensionSignInfo Include=".ttf" CertificateName="None" />
|
43 | 43 | <FileExtensionSignInfo Include=".otf" CertificateName="None" />
|
44 |
| - <FileExtensionSignInfo Remove=".js" /> |
45 |
| - <FileExtensionSignInfo Include=".js" CertificateName="None" /> |
| 44 | + |
| 45 | + <!-- We don't need to code sign .js files because they are not used in Windows Script Host. --> |
| 46 | + <FileExtensionSignInfo Update=".js" CertificateName="None" /> |
| 47 | + |
| 48 | + <!-- Skip signing .py files because they are already signed --> |
| 49 | + <FileExtensionSignInfo Update=".py" CertificateName="None" /> |
| 50 | + <FileExtensionSignInfo Include=".pyd" CertificateName="None" /> |
| 51 | + <FileExtensionSignInfo Include=".cat" CertificateName="None" /> |
| 52 | + |
| 53 | + <!-- Zero length files should not be signed because it breaks signing/ESRP. --> |
| 54 | + <FileSignInfo Include="__init__.py" CertificateName="None" /> |
| 55 | + <FileSignInfo Include="eggs.py" CertificateName="None" /> |
46 | 56 | </ItemGroup>
|
47 | 57 |
|
48 | 58 | <!--
|
49 |
| - These are third party libraries that we use in Arcade. We need to sign them even if they |
50 |
| - are already signed. However, they must be signed with a 3rd party certificate. |
| 59 | + Arcade is no longer signed so we don't have to sign test assemblies. |
| 60 | + ReSign 3rd party files that we use in the product |
51 | 61 | -->
|
52 | 62 | <ItemGroup>
|
53 | 63 | <FileSignInfo Include="MessagePack.Annotations.dll" CertificateName="$(ExternalCertificateId)" />
|
54 | 64 | <FileSignInfo Include="MessagePack.dll" CertificateName="$(ExternalCertificateId)" />
|
55 | 65 | <FileSignInfo Include="Nerdbank.Streams.dll" CertificateName="$(ExternalCertificateId)" />
|
56 | 66 | <FileSignInfo Include="Newtonsoft.Json.dll" CertificateName="$(ExternalCertificateId)" />
|
57 |
| - <FileSignInfo Include="CommandLine.dll" CertificateName="$(ExternalCertificateId)" /> |
58 |
| - <FileSignInfo Include="FluentAssertions.dll" CertificateName="$(ExternalCertificateId)" /> |
59 |
| - <FileSignInfo Include="FluentAssertions.Core.dll" CertificateName="$(ExternalCertificateId)" /> |
60 |
| - <FileSignInfo Include="FluentAssertions.Json.dll" CertificateName="$(ExternalCertificateId)" /> |
61 |
| - <FileSignInfo Include="Microsoft.3rdpartytools.MarkdownLog.dll" CertificateName="$(ExternalCertificateId)" /> |
62 |
| - <FileSignInfo Include="xunit.performance.api.dll" CertificateName="$(ExternalCertificateId)" /> |
63 |
| - <FileSignInfo Include="xunit.performance.core.dll" CertificateName="$(ExternalCertificateId)" /> |
64 |
| - <FileSignInfo Include="xunit.performance.execution.dll" CertificateName="$(ExternalCertificateId)" /> |
65 |
| - <FileSignInfo Include="xunit.performance.metrics.dll" CertificateName="$(ExternalCertificateId)" /> |
66 | 67 | <FileSignInfo Include="Valleysoft.DockerCredsProvider.dll" CertificateName="$(ExternalCertificateId)" />
|
| 68 | + |
| 69 | + <!-- Additionally, we need to notarize any .pkg files --> |
| 70 | + <MacOSPkg Include="$(ArtifactsShippingPackagesDir)**/dotnet-sdk*.pkg" Exclude="$(ArtifactsShippingPackagesDir)**/dotnet-sdk-internal*.pkg" /> |
| 71 | + <FileSignInfo Include="@(MacOSPkg->'%(Filename)%(Extension)')" CertificateName="MacDeveloperWithNotarization" /> |
67 | 72 | </ItemGroup>
|
68 | 73 |
|
69 | 74 | <ItemGroup>
|
|
82 | 87 | Kind="Package" />
|
83 | 88 | </ItemGroup>
|
84 | 89 |
|
| 90 | + <ItemGroup Condition="'$(DotNetBuild)' != 'true' or '$(BuildWorkloads)' == 'true'"> |
| 91 | + <Artifact Include="$(VisualStudioSetupInsertionPath)\**\*.zip" |
| 92 | + IsShipping="true" |
| 93 | + Kind="Blob" /> |
| 94 | + </ItemGroup> |
| 95 | + |
85 | 96 | <!-- Only publish this file from win-x64 so that we don't end up with duplicates. -->
|
86 | 97 | <ItemGroup Condition="'$(PublishBinariesAndBadge)' == 'true' and '$(OS)' == 'Windows_NT' and '$(TargetArchitecture)' == 'x64' and '$(PgoInstrument)' != 'true' and ('$(DotNetBuildPass)' == '' or '$(DotNetBuildPass)' == '1')">
|
87 | 98 | <SdkArtifact Include="$(ArtifactsShippingPackagesDir)productVersion.txt" />
|
|
0 commit comments