Skip to content

Commit 44b2f12

Browse files
hanidamlajfacebook-github-bot
authored andcommitted
remove cca hallucinated comments
Summary: unit test hygiene, remove comments that are wrong/inaccurate Reviewed By: joanna-jo Differential Revision: D81501021 fbshipit-source-id: f5d2a90029fa49ceec375282faddd80fb62bf80e
1 parent 70d44bc commit 44b2f12

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

proxygen/lib/http/coro/test/HTTPDownstreamCoroSessionTests.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1979,8 +1979,7 @@ TEST_P(HTTPDownstreamSessionTest, HoldContext) {
19791979

19801980
TEST_P(H2DownstreamSessionTest, ResetStreamNoError) {
19811981
// Client sends RST_STREAM with NO_ERROR while server has not finished
1982-
// consuming ingress. This used to trigger a CHECK in
1983-
// ErrorCode2HTTPErrorCode(NO_ERROR) prior to the fix.
1982+
// consuming ingress.
19841983
sendRequest("/", nullptr, /*eom=*/false, /*eof=*/false);
19851984

19861985
auto handler =
@@ -1991,22 +1990,22 @@ TEST_P(H2DownstreamSessionTest, ResetStreamNoError) {
19911990
auto id = *requestSource.getStreamID();
19921991
co_await expectRequest(
19931992
requestSource, HTTPMethod::GET, "/", /*eom=*/false);
1993+
19941994
// Inbound RST_STREAM with NO_ERROR from the peer.
19951995
resetStream(id, ErrorCode::NO_ERROR);
1996-
// Some transports in tests expect an extra read tick to drain.
1997-
transport_->addReadEvent(writeBuf_.move(), /*eom*/ true);
1996+
transport_->addReadEvent(writeBuf_.move(), /*eom=*/true);
1997+
19981998
// Expect the body read to surface a CANCEL error (normalized).
19991999
auto bodyEvent =
20002000
co_await co_awaitTry(readBodyEventNoSuspend(requestSource));
20012001
EXPECT_TRUE(bodyEvent.hasException());
2002+
20022003
auto err = getHTTPError(bodyEvent);
20032004
EXPECT_TRUE(isCancelled(err.code));
2004-
EXPECT_TRUE(err.msg.ends_with("details=received RST_STREAM from peer"));
20052005
co_return nullptr;
20062006
});
20072007

20082008
evb_.loop();
2009-
parseOutput();
20102009
}
20112010

20122011
// H2 only, H1 needs to test with transport write error

0 commit comments

Comments
 (0)