Support pool counters for CONNECT

Summary:
Pool counters including:
- conn and new_conn (former is # current conns, latter is a counter for like rate.60 or something)
- ingress and egress bytes
- req, and class codes (2xx, 3xx, etc)

I didn't include server latency because it doesn't really make sense for CONNECT sessions

Reviewed By: kwaugh

Differential Revision: D81638796

fbshipit-source-id: 9c9c564660370b364bda3b3ff8cd6a6ef9ca4d5e

Author: Jacob Steinebronn

proxygen/lib/http/sink/HTTPConnectSink.cpp

@@ -35,6 +35,9 @@ void HTTPConnectSink::sendBody(std::unique_ptr<folly::IOBuf> body) {
   DestructorCheck::Safety safety(*this);
   resetIdleTimeout();
   ++outstandingWrites_;
+  if (stats_ && body) {
+    stats_->addEgressBodyBytes(body->computeChainDataLength());
+  }
   sock_->writeChain(this, std::move(body));
   if (safety.destroyed()) {
     return;
@@ -129,6 +132,9 @@ void HTTPConnectSink::readDataAvailable(size_t readSize) noexcept {
     while (readBuf_.front()->length() == 0) {
       readBuf_.pop_front();
     }
+    if (stats_) {
+      stats_->addIngressBodyBytes(readBuf_.front()->length());
+    }
     handler_->onBody(readBuf_.pop_front());
   }
 }

proxygen/lib/http/sink/HTTPConnectSink.h

@@ -7,6 +7,7 @@
  */
 
 #pragma once
+#include "proxygen/facebook/revproxy/pools/Pool.h"
 #include <folly/io/async/AsyncSocket.h>
 #include <folly/io/async/AsyncTransport.h>
 #include <proxygen/lib/http/session/HTTPTransaction.h>
@@ -27,14 +28,30 @@ class HTTPConnectSink
 
  public:
   explicit HTTPConnectSink(folly::AsyncTransport::UniquePtr socket,
-                           HTTPTransactionHandler* handler)
+                           HTTPTransactionHandler* handler,
+                           std::shared_ptr<Pool> pool = nullptr)
       : sock_(std::move(socket)), handler_(handler) {
     CHECK(sock_);
     sock_->getLocalAddress(&localAddress_);
     sock_->getPeerAddress(&peerAddress_);
+
+    if (pool) {
+      stats_ = pool->getConnectionStats();
+    }
+    if (stats_) {
+      stats_->recordConnectionOpen();
+      stats_->recordTcpConnectionOpen();
+      stats_->recordRequest();
+      stats_->recordResponse(200);
+    }
   }
 
-  ~HTTPConnectSink() override = default;
+  ~HTTPConnectSink() override {
+    if (stats_) {
+      stats_->recordDuration(millisecondsSince(connStart_).count());
+      stats_->recordConnectionClose();
+    }
+  }
 
   [[nodiscard]] folly::Optional<HTTPCodec::StreamID> getStreamID()
       const override {
@@ -197,6 +214,8 @@ class HTTPConnectSink
   folly::SocketAddress peerAddress_;
   folly::SocketAddress localAddress_;
   wangle::TransportInfo transportInfo_;
+  ConnectionStats* stats_ = nullptr;
+  const TimePoint connStart_{getCurrentTime()};
 
   /** Chain of ingress IOBufs */
   folly::IOBufQueue readBuf_{folly::IOBufQueue::cacheChainLength()};