Skip to content

Commit 3fd995a

Browse files
committed
no override by shutdown/pause
1 parent 35013b0 commit 3fd995a

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

db/compaction/compaction_iterator.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1120,16 +1120,16 @@ void CompactionIterator::NextFromInput() {
11201120
}
11211121
}
11221122

1123-
if (!Valid() && IsShuttingDown()) {
1123+
if (!Valid() && status_.ok() && IsShuttingDown()) {
11241124
status_ = Status::ShutdownInProgress();
11251125
}
11261126

1127-
if (IsPausingManualCompaction()) {
1127+
if (status_.ok() && IsPausingManualCompaction()) {
11281128
status_ = Status::Incomplete(Status::SubCode::kManualCompactionPaused);
11291129
}
11301130

11311131
// Propagate corruption status from memtable itereator
1132-
if (!input_.Valid() && input_.status().IsCorruption()) {
1132+
if (status_.ok() && !input_.Valid() && input_.status().IsCorruption()) {
11331133
status_ = input_.status();
11341134
}
11351135
}

db/compaction/compaction_job.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1610,11 +1610,10 @@ Status CompactionJob::FinalizeProcessKeyValueStatus(
16101610
status =
16111611
Status::ColumnFamilyDropped("Column family dropped during compaction");
16121612
}
1613-
if ((status.ok() || status.IsColumnFamilyDropped()) &&
1614-
shutting_down_->load(std::memory_order_relaxed)) {
1613+
if (status.ok() && shutting_down_->load(std::memory_order_relaxed)) {
16151614
status = Status::ShutdownInProgress("Database shutdown");
16161615
}
1617-
if ((status.ok() || status.IsColumnFamilyDropped()) &&
1616+
if (status.ok() &&
16181617
(manual_compaction_canceled_.load(std::memory_order_relaxed))) {
16191618
status = Status::Incomplete(Status::SubCode::kManualCompactionPaused);
16201619
}

0 commit comments

Comments
 (0)