Skip to content

Conversation

bary12
Copy link
Contributor

@bary12 bary12 commented Dec 15, 2017

This pull request introduces two major changes:

  • Fixers. The following rules are now fixable with --fix. This is Issue Add fixers to a few rules #53
    • check-types
    • newline-after-description
    • require-description-complete-sentence
    • require-hyphen-before-param-description
  • require-description-complete-sentence now checks that after a period there's an upper case letter. Before, it only checked the beginning of paragraphs.

All this new behavior is tested.

@gajus
Copy link
Owner

gajus commented Dec 15, 2017

Is this ready to be reviewed/ merged?

@bary12
Copy link
Contributor Author

bary12 commented Dec 15, 2017

Yes, I made a little mess with the commits but I think it's ready.

@gajus gajus merged commit 0e6b80e into gajus:master Dec 15, 2017
@gajus
Copy link
Owner

gajus commented Dec 15, 2017

Thank you

@bary12 bary12 mentioned this pull request Dec 15, 2017
@bary12 bary12 deleted the description-full-sentence-fixer branch December 15, 2017 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants