Skip to content

Commit 7c00dd0

Browse files
committed
fix: canary only worked when gateway enabled
1 parent 9bdd5d1 commit 7c00dd0

File tree

4 files changed

+14
-1
lines changed

4 files changed

+14
-1
lines changed

docs/sources/setup/install/helm/reference.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6690,6 +6690,15 @@ null
66906690
<td><pre lang="json">
66916691
"pod"
66926692
</pre>
6693+
</td>
6694+
</tr>
6695+
<tr>
6696+
<td>lokiCanary.lokiurl</td>
6697+
<td>string</td>
6698+
<td>If set overwrites the default value set by loki.host helper function. Use this if gateway not enabled.</td>
6699+
<td><pre lang="json">
6700+
null
6701+
</pre>
66936702
</td>
66946703
</tr>
66956704
<tr>

production/helm/loki/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ Entries should include a reference to the pull request that introduced the chang
1313

1414
[//]: # (<AUTOMATED_UPDATES_LOCATOR> : do not remove this line. This locator is used by the CI pipeline to automatically create a changelog entry for each new Loki release. Add other chart versions and respective changelog entries bellow this line.)
1515

16+
- [BUGFIX] Loki endpoint for Canary assumed gateway was always enabled. Can now be overwritten through values.
17+
1618
## 6.28.0
1719

1820
- [CHANGE] Add extraContainers parameter for the backend pod

production/helm/loki/templates/loki-canary/daemonset.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ spec:
4141
image: {{ include "loki-canary.image" $ }}
4242
imagePullPolicy: {{ $.Values.loki.image.pullPolicy }}
4343
args:
44-
- -addr={{- include "loki.host" $ }}
44+
- -addr={{- default (include "loki.host" $) .lokiurl }}
4545
- -labelname={{ .labelname }}
4646
- -labelvalue=$(POD_NAME)
4747
{{- if $.Values.enterprise.enabled }}

production/helm/loki/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -749,6 +749,8 @@ lokiCanary:
749749
# -- If true, the canary will send directly to Loki via the address configured for verification --
750750
# -- If false, it will write to stdout and an Agent will be needed to scrape and send the logs --
751751
push: true
752+
# -- If set overwrites the default value set by loki.host helper function. Use this if gateway not enabled.
753+
lokiurl: null
752754
# -- The name of the label to look for at loki when doing the checks.
753755
labelname: pod
754756
# -- Additional annotations for the `loki-canary` Daemonset

0 commit comments

Comments
 (0)