Skip to content

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Mar 18, 2025

What this PR does / why we need it:

This pull request fixes a panic in ServeHTTP where nil was appended to a slice by mistake.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner March 18, 2025 16:17
@grobinson-grafana grobinson-grafana force-pushed the grobinson/fix-panic-in-http-handler branch from fdeca34 to 7784f5d Compare March 18, 2025 16:18
@grobinson-grafana grobinson-grafana force-pushed the grobinson/fix-panic-in-http-handler branch from 7784f5d to 8eec1a4 Compare March 18, 2025 16:28
@grobinson-grafana grobinson-grafana merged commit ba7550a into main Mar 18, 2025
61 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/fix-panic-in-http-handler branch March 18, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants