Skip to content

Conversation

yann-soubeyrand
Copy link
Contributor

What this PR does / why we need it:

The Helm chart has a global section where one can put extraArgs, extraEnv, extraEnvFrom, extraVolumes and extraVolumeMounts configuration. This is working fine for the write component, but it is not working for the read component and extraEnvFrom is not working for the backend component. This PR fixes this.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@yann-soubeyrand yann-soubeyrand force-pushed the fix-chart-extra-args-env-env-from branch from 3389335 to 619ba1b Compare May 22, 2025 15:22
@yann-soubeyrand
Copy link
Contributor Author

Hi @poyzannur, thanks for having merged #16828. Could you have a look at this PR which further fixes extraArgs, extraVolumes and extraVolumeMounts for the read, bloomPlanner and tableManager components?

@poyzannur
Copy link
Contributor

Thanks so much for the fixes @yann-soubeyrand

@poyzannur poyzannur merged commit 7c50c2d into grafana:main May 26, 2025
74 checks passed
@yann-soubeyrand yann-soubeyrand deleted the fix-chart-extra-args-env-env-from branch May 26, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants