feat(dataobj, executor): filter node execution #17327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
reviewed
Apr 22, 2025
pkg/engine/executor/executor.go
Outdated
| } | ||
|
|
||
| return errorPipeline(errNotImplemented) | ||
| return NewFilterPipeline(filter, inputs[0], &c.evaluator) |
There was a problem hiding this comment.
nit: The expression evaluator is stateless, so it does not require to pass a pointer.
| // boolean filters are only used for filtering; they're not returned | ||
| // and must be released | ||
| // TODO: verify this once the evaluator implementation is fleshed out | ||
| col.Release() |
There was a problem hiding this comment.
I think we need a nil check here, in case not all columns where initialized.
There was a problem hiding this comment.
I don't think so; it's initialized with capacity, but len=0. Length only increases when columns are added.
pkg/engine/executor/filter_test.go
Outdated
| AssertPipelinesEqual(t, filterPipeline, expectedPipeline) | ||
| }) | ||
|
|
||
| t.Run("filter using valid column directly", func(t *testing.T) { |
There was a problem hiding this comment.
nit: I found the test name confusing. The test is validating that you can filter on a boolean column with a simple ColumnExpr.
This implementation provides a foundation for more advanced filtering operations as the expression evaluator is enhanced to support more complex expressions.
👍
chaudum
approved these changes
Apr 24, 2025
This was referenced Jun 24, 2025
This was referenced Jul 7, 2025
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Filter Pipeline Implementation
This PR implements a filter pipeline for Loki's engine executor component. The filter operator enables row-level filtering of Arrow record batches based on boolean expressions. This is a fundamental component for query execution.
Changes
NewFilterPipelinefor evaluating filter predicates on record batchesfilterBatchutility to efficiently filter Arrow recordsexecuteFilterin the executor to use the new implementationImplementation Notes
The filter implementation follows the same pattern as the project pipeline, evaluating predicates against each record and creating a new filtered record based on the results. The implementation supports compound predicates with AND logic.
This implementation provides a foundation for more advanced filtering operations as the expression evaluator is enhanced to support more complex expressions.