-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(operator): allow users to configure virtual-host-style for S3 secrets #17363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work great, left a comment if we should further simplify it (if I have not forgotten something).
Thanks for cleaning up the docs a bit as well 👍
Co-authored-by: Robert Jacob <[email protected]> Signed-off-by: Joao Marcal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, approving. 👍
I have left two comments on the PR, I think I'd consider them "optional".
Co-authored-by: Robert Jacob <[email protected]> Signed-off-by: Joao Marcal <[email protected]>
What this PR does / why we need it:
https://issues.redhat.com/browse/LOG-6641
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR