Skip to content

Conversation

jplitza
Copy link
Contributor

@jplitza jplitza commented May 2, 2025

What this PR does / why we need it:
Previously, setting .Values.networkPolicy.metrics.cidrs to a non-empty list was required to include the configured .Values.networkPolicy.metrics.namespaceSelector

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Previously, setting .Values.networkPolicy.metrics.cidrs to a non-empty list was required to include the configured .Values.networkPolicy.metrics.namespaceSelector

Signed-off-by: Jan-Philipp Litza <[email protected]>
@jplitza jplitza requested a review from a team as a code owner May 2, 2025 14:42
@CLAassistant
Copy link

CLAassistant commented May 2, 2025

CLA assistant check
All committers have signed the CLA.

@jkroepke
Copy link
Contributor

LGTM

@Jayclifford345 Jayclifford345 merged commit 3a9b8e8 into grafana:main Jul 8, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants