feat: Re-implement ExceedsLimits in ingest-limits-frontend #17576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
force-pushed
the
grobinson/reimplement-exceeds-limits-in-frontend
branch
2 times, most recently
from
52f04ba to
a458a2e
Compare
| }}, | ||
| }, nil}, | ||
| exceedsLimitsResponseErrs: []error{nil, errors.New("an unexpected error occurred")}, | ||
| expectedErr: "an unexpected error occurred", |
There was a problem hiding this comment.
This will change once we figure out what to do when we cannot get an answer for a partition.
periklis
approved these changes
May 6, 2025
grobinson-grafana
force-pushed
the
grobinson/reimplement-exceeds-limits-in-frontend
branch
from
a458a2e to
01f9000
Compare
grobinson-grafana
force-pushed
the
grobinson/reimplement-exceeds-limits-in-frontend
branch
from
01f9000 to
bc9d753
Compare
grobinson-grafana
deleted the
grobinson/reimplement-exceeds-limits-in-frontend
branch
This was referenced Jul 7, 2025
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request re-implements
ExceedsLimitsin theingest-limits-frontendto use the newExceedsLimitsRPC call instead ofGetStreamUsage.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR