Skip to content

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented May 6, 2025

What this PR does / why we need it:

This pull request should fix a lint error in main:

Warning: unused-parameter: parameter 'partitionID' seems to be unused, consider removing or renaming it as _ (revive)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner May 6, 2025 21:04
@grobinson-grafana grobinson-grafana changed the title Fix lint error in main branch fix: lint error in main branch May 6, 2025
@grobinson-grafana grobinson-grafana enabled auto-merge (squash) May 6, 2025 21:06
@grobinson-grafana grobinson-grafana merged commit 93eaf5f into main May 6, 2025
66 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/fix-lint-in-main branch May 6, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants