Skip to content

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented May 8, 2025

What this PR does / why we need it:
This pull request provides a small fix in the ingest limits Kafka-WAL constructor to use the correct topic.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this May 8, 2025
@periklis periklis requested a review from a team as a code owner May 8, 2025 18:09
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think call this something like loki-local-config-ingest-limits-experiemental.yaml to discourage people from using it in their installations 😄

@periklis periklis merged commit cdbe3b3 into main May 9, 2025
65 checks passed
@periklis periklis deleted the fix-ingest-limits-kafka-setup branch May 9, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants