Skip to content

Conversation

aarogoss
Copy link
Contributor

@aarogoss aarogoss commented May 20, 2025

When capturing statistics regarding the most recent push request, extract the User-Agent header value from the request headers. If this value is included, strip off the trailing '/.*' content and include the agent value in the log line.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Adds User-Agent to the distributor logging so we can track agent types along with lag metrics.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

When capturing statistics regarding the most recent push request,
extract the `User-Agent` header value from the request headers.  If this
value is included, strip off the trailing '/.*' content and include the
agent value in the log line.
@aarogoss aarogoss self-assigned this May 20, 2025
@aarogoss aarogoss marked this pull request as ready for review May 20, 2025 16:37
@aarogoss aarogoss requested a review from a team as a code owner May 20, 2025 16:37
@aarogoss aarogoss enabled auto-merge (squash) May 20, 2025 16:38
@aarogoss aarogoss merged commit 2902964 into main May 20, 2025
66 checks passed
@aarogoss aarogoss deleted the agoss/add-useragent-to-distributor-logging branch May 20, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants