Skip to content

fix(ruler): Return StatusBadRequest on multiple org IDs #17850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

fix(ruler): Return StatusBadRequest on multiple org IDs #17850

merged 2 commits into from
Jun 2, 2025

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented May 28, 2025 •
edited
Loading

What this PR does / why we need it:
This pull request provides a small fix to return BadRequest as the status code when a client if sending multiple org ids to the ruler API.

Which issue(s) this PR fixes:
Fixes #grafana/loki-private/issues/1335

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis force-pushed the fix-ruler-multiple-orgids branch from 0d14b07 to 22179ab Compare June 2, 2025 07:43
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 2, 2025
@periklis periklis marked this pull request as ready for review June 2, 2025 07:43
@periklis periklis requested a review from a team as a code owner June 2, 2025 07:43
@periklis periklis self-assigned this Jun 2, 2025
ashwanthgoli
ashwanthgoli approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@periklis periklis merged commit f7e47f0 into main Jun 2, 2025
65 checks passed
@periklis periklis deleted the fix-ruler-multiple-orgids branch June 2, 2025 07:56
@periklis periklis added type/bug Somehing is not working as expected backport k257 labels Jun 2, 2025
loki-gh-app bot pushed a commit that referenced this pull request Jun 2, 2025
@periklis @grafana-delivery-bot
fix(ruler): Return StatusBadRequest on multiple org IDs (#17850)
b832023 
(cherry picked from commit f7e47f0)
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 2, 2025
Merged
6 tasks
This was referenced Aug 5, 2025
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Aug 18, 2025
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 1, 2025
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 8, 2025
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwanthgoli ashwanthgoli ashwanthgoli approved these changes

Assignees

@periklis periklis

Labels
backport k257 size/L type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@periklis @ashwanthgoli