Skip to content

fix: Row reader with no stream ID predicates #18368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2025
Merged

fix: Row reader with no stream ID predicates #18368

merged 4 commits into from
Jul 9, 2025

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Jul 9, 2025

What this PR does / why we need it:
Fix row reader when there are no stream predicates

  • I previously removed the if statement for no values, which I added back here and included a test to confirm.

@benclive benclive requested a review from a team as a code owner July 9, 2025 09:45
ashwanthgoli
ashwanthgoli approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benclive benclive enabled auto-merge (squash) July 9, 2025 11:26
@benclive benclive merged commit f66781d into main Jul 9, 2025
65 checks passed
@benclive benclive deleted the fix-streamIDPredicate-for-logs branch July 9, 2025 11:29
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 8, 2025
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwanthgoli ashwanthgoli ashwanthgoli approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benclive @ashwanthgoli